linux-kernel - Re: [PATCH net-next 12/13] net: phy: dp83822: Add SFP support through the phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202502090056.jTCOvIPk-lkp@intel.com>
Date: Sun, 9 Feb 2025 00:15:18 +0800
From: kernel test robot <lkp@...el.com>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>, davem@...emloft.net
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Maxime Chevallier <maxime.chevallier@...tlin.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, thomas.petazzoni@...tlin.com,
	Andrew Lunn <andrew@...n.ch>, Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Russell King <linux@...linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Herve Codina <herve.codina@...tlin.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Vladimir Oltean <vladimir.oltean@....com>,
	Köry Maincent <kory.maincent@...tlin.com>,
	Marek Behún <kabel@...nel.org>,
	Oleksij Rempel <o.rempel@...gutronix.de>,
	Nicolò Veronese <nicveronese@...il.com>,
	Simon Horman <horms@...nel.org>, mwojtas@...omium.org,
	Antoine Tenart <atenart@...nel.org>, devicetree@...r.kernel.org,
	Conor Dooley <conor+dt@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Romain Gantois <romain.gantois@...tlin.com>
Subject: Re: [PATCH net-next 12/13] net: phy: dp83822: Add SFP support
 through the phy_port interface

Hi Maxime,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Maxime-Chevallier/net-ethtool-Introduce-ETHTOOL_LINK_MEDIUM_-values/20250208-064223
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250207223634.600218-13-maxime.chevallier%40bootlin.com
patch subject: [PATCH net-next 12/13] net: phy: dp83822: Add SFP support through the phy_port interface
config: i386-buildonly-randconfig-004-20250208 (https://download.01.org/0day-ci/archive/20250209/202502090056.jTCOvIPk-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250209/202502090056.jTCOvIPk-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502090056.jTCOvIPk-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/net/phy/dp83822.c:916:43: error: use of undeclared identifier 'interfaces'
     916 |                 __set_bit(PHY_INTERFACE_MODE_100BASEFX, interfaces);
         |                                                         ^
>> drivers/net/phy/dp83822.c:916:13: error: use of undeclared identifier 'PHY_INTERFACE_MODE_100BASEFX'; did you mean 'PHY_INTERFACE_MODE_100BASEX'?
     916 |                 __set_bit(PHY_INTERFACE_MODE_100BASEFX, interfaces);
         |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                           PHY_INTERFACE_MODE_100BASEX
   include/linux/bitops.h:54:48: note: expanded from macro '__set_bit'
      54 | #define __set_bit(nr, addr)             bitop(___set_bit, nr, addr)
         |                                                           ^
   include/linux/bitops.h:44:25: note: expanded from macro 'bitop'
      44 |         ((__builtin_constant_p(nr) &&                                   \
         |                                ^
   include/linux/phy.h:140:2: note: 'PHY_INTERFACE_MODE_100BASEX' declared here
     140 |         PHY_INTERFACE_MODE_100BASEX,
         |         ^
>> drivers/net/phy/dp83822.c:916:43: error: use of undeclared identifier 'interfaces'
     916 |                 __set_bit(PHY_INTERFACE_MODE_100BASEFX, interfaces);
         |                                                         ^
>> drivers/net/phy/dp83822.c:916:43: error: use of undeclared identifier 'interfaces'
   drivers/net/phy/dp83822.c:916:13: error: use of undeclared identifier 'PHY_INTERFACE_MODE_100BASEFX'
     916 |                 __set_bit(PHY_INTERFACE_MODE_100BASEFX, interfaces);
         |                           ^
>> drivers/net/phy/dp83822.c:916:43: error: use of undeclared identifier 'interfaces'
     916 |                 __set_bit(PHY_INTERFACE_MODE_100BASEFX, interfaces);
         |                                                         ^
   drivers/net/phy/dp83822.c:916:13: error: use of undeclared identifier 'PHY_INTERFACE_MODE_100BASEFX'
     916 |                 __set_bit(PHY_INTERFACE_MODE_100BASEFX, interfaces);
         |                           ^
>> drivers/net/phy/dp83822.c:916:43: error: use of undeclared identifier 'interfaces'
     916 |                 __set_bit(PHY_INTERFACE_MODE_100BASEFX, interfaces);
         |                                                         ^
   8 errors generated.


vim +/interfaces +916 drivers/net/phy/dp83822.c

   899	
   900			if (dp83822->fx_enabled) {
   901				port->lanes = 1;
   902				port->mediums = BIT(ETHTOOL_LINK_MEDIUM_BASEF) |
   903						BIT(ETHTOOL_LINK_MEDIUM_BASEX);
   904			} else {
   905				/* This PHY can only to 100BaseTX max, so on 2 lanes */
   906				port->lanes = 2;
   907				port->mediums = BIT(ETHTOOL_LINK_MEDIUM_BASET);
   908			}
   909		}
   910	
   911		/* If attached from SFP, is_serdes is set, but not the mediums. */
   912		if (port->is_serdes)
   913			dp83822->fx_enabled = true;
   914	
   915		if (dp83822->fx_enabled)
 > 916			__set_bit(PHY_INTERFACE_MODE_100BASEFX, interfaces);
   917	
   918		return 0;
   919	}
   920	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki