linux-kernel - drivers/scsi/mpi3mr/mpi3mr_app.c:745: warning: Excess function parameter 'data' description in 'mpi3mr_set_trigger_data_in_all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202502090051.wC6ZLMrq-lkp@intel.com>
Date: Sun, 9 Feb 2025 00:59:44 +0800
From: kernel test robot <lkp@...el.com>
To: Ranjan Kumar <ranjan.kumar@...adcom.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Sathya Prakash <sathya.prakash@...adcom.com>
Subject: drivers/scsi/mpi3mr/mpi3mr_app.c:745: warning: Excess function
 parameter 'data' description in 'mpi3mr_set_trigger_data_in_all_hdb'

Hi Ranjan,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   8f6629c004b193d23612641c3607e785819e97ab
commit: d8d08d1638ce1c237ce9c3f14649a3a4cf1b1749 scsi: mpi3mr: Trigger support
date:   8 months ago
config: x86_64-randconfig-a013-20211029 (https://download.01.org/0day-ci/archive/20250209/202502090051.wC6ZLMrq-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250209/202502090051.wC6ZLMrq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502090051.wC6ZLMrq-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/scsi/mpi3mr/mpi3mr_app.c:718: warning: Excess function parameter 'data' description in 'mpi3mr_set_trigger_data_in_hdb'
>> drivers/scsi/mpi3mr/mpi3mr_app.c:745: warning: Excess function parameter 'data' description in 'mpi3mr_set_trigger_data_in_all_hdb'


vim +745 drivers/scsi/mpi3mr/mpi3mr_app.c

   700	
   701	/**
   702	 * mpi3mr_set_trigger_data_in_hdb - Updates HDB trigger type and
   703	 * trigger data
   704	 *
   705	 * @hdb: HDB pointer
   706	 * @type: Trigger type
   707	 * @data: Trigger data
   708	 * @force: Trigger overwrite flag
   709	 * @trigger_data: Pointer to trigger data information
   710	 *
   711	 * Updates trigger type and trigger data based on parameter
   712	 * passed to this function
   713	 *
   714	 * Return: Nothing
   715	 */
   716	void mpi3mr_set_trigger_data_in_hdb(struct diag_buffer_desc *hdb,
   717		u8 type, union mpi3mr_trigger_data *trigger_data, bool force)
 > 718	{
   719		if ((!force) && (hdb->trigger_type != MPI3MR_HDB_TRIGGER_TYPE_UNKNOWN))
   720			return;
   721		hdb->trigger_type = type;
   722		if (!trigger_data)
   723			memset(&hdb->trigger_data, 0, sizeof(*trigger_data));
   724		else
   725			memcpy(&hdb->trigger_data, trigger_data, sizeof(*trigger_data));
   726	}
   727	
   728	/**
   729	 * mpi3mr_set_trigger_data_in_all_hdb - Updates HDB trigger type
   730	 * and trigger data for all HDB
   731	 *
   732	 * @mrioc: Adapter instance reference
   733	 * @type: Trigger type
   734	 * @data: Trigger data
   735	 * @force: Trigger overwrite flag
   736	 * @trigger_data: Pointer to trigger data information
   737	 *
   738	 * Updates trigger type and trigger data based on parameter
   739	 * passed to this function
   740	 *
   741	 * Return: Nothing
   742	 */
   743	void mpi3mr_set_trigger_data_in_all_hdb(struct mpi3mr_ioc *mrioc,
   744		u8 type, union mpi3mr_trigger_data *trigger_data, bool force)
 > 745	{
   746		struct diag_buffer_desc *hdb = NULL;
   747	
   748		hdb = mpi3mr_diag_buffer_for_type(mrioc, MPI3_DIAG_BUFFER_TYPE_TRACE);
   749		if (hdb)
   750			mpi3mr_set_trigger_data_in_hdb(hdb, type, trigger_data, force);
   751		hdb = mpi3mr_diag_buffer_for_type(mrioc, MPI3_DIAG_BUFFER_TYPE_FW);
   752		if (hdb)
   753			mpi3mr_set_trigger_data_in_hdb(hdb, type, trigger_data, force);
   754	}
   755	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki