linux-kernel - Re: [PATCH v1 9/9] arm64: dts: exynos990: define all PERIC USI nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D7NB1L54MHGG.MHALKBC8531M@mentallysanemainliners.org>
Date: Sat, 08 Feb 2025 19:18:14 +0000
From: "Umer Uddin" <umer.uddin@...tallysanemainliners.org>
To: <wachiturroxd150@...il.com>
Cc: <alim.akhtar@...sung.com>, <krzk@...nel.org>,
 <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
 <linux-samsung-soc@...r.kernel.org>
Subject: Re: [PATCH v1 9/9] arm64: dts: exynos990: define all PERIC USI
 nodes

Hi Denzeel, thank you for your patches.

> +                     samsung,mode = <USI_V2_UART>;
[...]
> +                     samsung,mode = <USI_V2_I2C>;

Although these definitions are valid, there are two issues. these will
never compile as you have forgotten to include the header file
"dt-bindings/soc/samsung,exynos-usi.h". Also USI_V2* definitions are
deprecated and you shoulud use USI_MODE* definitions instead.

> +                             fifo-depth = <256>

You are missing a semi-colon. (This applies for nodes spi_8, spi_9 and
spi_10).

Please rectify these errors.

Regards, Umer