linux-kernel - Re: [PATCH 00/14] drm/panel: Transition away from using mipi_dsi_*_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=WkPefg00R_TAQQA6waRqGdD+3e84JXfPLk2i9BRzW6Yg@mail.gmail.com>
Date: Sat, 8 Feb 2025 12:37:43 -0800
From: Doug Anderson <dianders@...omium.org>
To: Anusha Srivatsa <asrivats@...hat.com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, Jessica Zhang <quic_jesszhan@...cinc.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Joel Selvaraj <jo@...amily.in>, Ondrej Jirman <megi@....cz>, 
	Javier Martinez Canillas <javierm@...hat.com>, Artur Weber <aweber.kernel@...il.com>, 
	Jianhua Lu <lujianhua000@...il.com>, Jonathan Corbet <corbet@....net>, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, 
	Tejas Vipin <tejasvipin76@...il.com>
Subject: Re: [PATCH 00/14] drm/panel: Transition away from using mipi_dsi_*_write_seq()

Hi,

On Thu, Feb 6, 2025 at 1:06 PM Anusha Srivatsa <asrivats@...hat.com> wrote:
>
> Transition away from mipi_dsi_generic_write_seq() and
> mipi_dsi_dcs_write_seq() to mipi_dsi_generic_write_seq_multi()
> and mipi_dsi_dcs_write_seq_multi() respectively.
>
> This is addressing one of the gpu todo items [1]
>
> Used Coccinelle to make the code changes.

As Dmitry mentioned [1], I think a real cleanup needs more thought
than can be done in a Coccinelle script. Maybe you can make a script
that's super fancy and does a perfect conversion, but I sorta doubt it
in this case.

A few other note:

* Tejas Vipin has been slowly whittling down this TODO item. It would
be good to CC him on any attempts to avoid duplicating work. He just
submitted a patch [2] that duplicates one of the panels you ran your
script on. It would also be good to look at the patches he has been
posting to see some of the extra complexities.

* I'm happy you CCed on the cover letter, but given that I've been
helping with this TODO entry it would have been nice to have been CCed
on all the patches.

For now I'm not going to review the individual patches in this series.
If there are any where you think your Coccinelle script really got
everything adjusted perfectly then feel free to point them out and
I'll review them. If you want to help with this effort, my own
personal preference would be to at least start w/ one panel at a time
since probably review feedback on all the conversions will be similar.

Thanks!

-Doug

[1] https://lore.kernel.org/r/mz6usiheb2lx6wlk47z3btvf6t6kbo4ja4n6mli5hosrpcvdwp@wmvfvhaqhpkm
[2] http://lore.kernel.org/r/20250208051541.176667-1-tejasvipin76@gmail.com