[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250208211325.992280-2-aren@peacevolution.org>
Date: Sat, 8 Feb 2025 16:13:18 -0500
From: Aren Moynihan <aren@...cevolution.org>
To: Jonathan Cameron <jic23@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Samuel Holland <samuel@...lland.org>
Cc: Aren Moynihan <aren@...cevolution.org>,
Kaustabh Chakraborty <kauschluss@...root.org>,
Barnabás Czémán <trabarni@...il.com>,
Julien Stephan <jstephan@...libre.com>,
Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
linux-iio@...r.kernel.org,
devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-sunxi@...ts.linux.dev,
Ondrej Jirman <megi@....cz>,
Dragan Simic <dsimic@...jaro.org>,
phone-devel@...r.kernel.org
Subject: [PATCH v5 0/8] iio: light: stk3310: support powering off during suspend
In the Pine64 PinePhone, the stk3310 chip is powered by a regulator that
is disabled at system boot and can be shut off during suspend. To ensure
that the chip properly initializes, both after boot and suspend, we need
to manage this regulator.
Additionally if the chip is shut off in suspend, we need to make sure
that it gets reinitialized with the same parameters after resume.
Changes in v5:
- inline STK3310_REGFIELD macro
- extract a separate dev variable instead of using &client->dev or
&data->client->dev
- make log / error message format consistent (no period and a newline
at the end)
- add error handling for devm_mutex_init
Major changes in v4:
- replace mutex_init with devm_mutex_init
- code style cleanup
Major changes in v3:
- Use bulk regulators instead of two individual ones
- Replace stk3310_remove with devm callbacks
Major changes in v2:
- Add handling of the IR LED. I was hesitant to include this as it is
the same as pull-up regulator for the i2c bus on the hardware I have,
so I can't test it well. I think leaving it out is more likely to
cause issues than including it.
- Convert stk3310 to use dev_err_probe for errors.
- Always enable / disable regulators and rely on dummy devices if
they're not specified.
- more listed in individual patches
Aren Moynihan (7):
dt-bindings: iio: light: stk33xx: add vdd and leda regulators
iio: light: stk3310: handle all remove logic with devm callbacks
iio: light: stk3310: implement vdd and leda supplies
iio: light: stk3310: simplify and inline STK3310_REGFIELD macro
iio: light: stk3310: refactor to always make dev a variable
iio: light: stk3310: use dev_err_probe where possible
iio: light: stk3310: log error if reading the chip id fails
Ondrej Jirman (1):
arm64: dts: allwinner: pinephone: add power supplies to stk3311
.../bindings/iio/light/stk33xx.yaml | 4 +
.../dts/allwinner/sun50i-a64-pinephone.dtsi | 2 +
drivers/iio/light/stk3310.c | 254 ++++++++++++------
3 files changed, 178 insertions(+), 82 deletions(-)
--
2.48.1
Powered by blists - more mailing lists