linux-kernel - [PATCH 1/2] HID: hid-appletb-kbd: make struct attribute *appletb_kbd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <3AE31FDA-2F6B-4CFA-9E19-0DEECE363D30@live.com>
Date: Sun, 9 Feb 2025 07:26:45 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: Jiri Kosina <jikos@...nel.org>, "jkosina@...e.com" <jkosina@...e.com>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>, "bentiss@...nel.org"
	<bentiss@...nel.org>
CC: Orlando Chamberlain <orlandoch.dev@...il.com>, Kerem Karabay
	<kekrby@...il.com>, "linux-input@...r.kernel.org"
	<linux-input@...r.kernel.org>, Linux Kernel Mailing List
	<linux-kernel@...r.kernel.org>
Subject: [PATCH 1/2] HID: hid-appletb-kbd: make struct attribute
 *appletb_kbd_attrs[] static

From: Aditya Garg <gargaditya08@...e.com>

This commit addresses the sparse warning flagged by the kernel test robot.

Reported-by: kernel test robot <lkp@...el.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202502091105.ZsLoBSIh-lkp@intel.com/
Signed-off-by: Aditya Garg <gargaditya08@...e.com>
---
 drivers/hid/hid-appletb-kbd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/hid-appletb-kbd.c b/drivers/hid/hid-appletb-kbd.c
index fa28a691d..38fc0e58c 100644
--- a/drivers/hid/hid-appletb-kbd.c
+++ b/drivers/hid/hid-appletb-kbd.c
@@ -4,7 +4,7 @@
  *
  * Copyright (c) 2017-2018 Ronald Tschalär
  * Copyright (c) 2022-2023 Kerem Karabay <kekrby@...il.com>
- * Copyright (c) 2024 Aditya Garg <gargaditya08@...e.com>
+ * Copyright (c) 2024-2025 Aditya Garg <gargaditya08@...e.com>
  */
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
@@ -143,7 +143,7 @@ static ssize_t mode_store(struct device *dev,
 }
 static DEVICE_ATTR_RW(mode);
 
-struct attribute *appletb_kbd_attrs[] = {
+static struct attribute *appletb_kbd_attrs[] = {
 	&dev_attr_mode.attr,
 	NULL
 };
-- 
2.43.0