linux-kernel - Re: [PATCH v2] hwrng: imx-rngc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z6iCn97oKQuXZd-Y@gondor.apana.org.au>
Date: Sun, 9 Feb 2025 18:25:35 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Martin Kaiser <martin@...ser.cx>
Cc: linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, Kamlesh Gurudasani <kamlesh@...com>
Subject: Re: [PATCH v2] hwrng: imx-rngc - add runtime pm

On Sat, Feb 01, 2025 at 07:39:07PM +0100, Martin Kaiser wrote:
> Add runtime power management to the imx-rngc driver. Disable the
> peripheral clock when the rngc is idle.
> 
> The callback functions from struct hwrng wake the rngc up when they're
> called and set it to idle on exit. Helper functions which are invoked
> from the callbacks assume that the rngc is active.
> 
> Device init and probe are done before runtime pm is enabled. The
> peripheral clock will be handled manually during these steps. Do not use
> devres any more to enable/disable the peripheral clock, this conflicts
> with runtime pm.
> 
> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> ---
> v2:
>  - remove unnecessary err = 0; assignment
> 
>  drivers/char/hw_random/imx-rngc.c | 69 +++++++++++++++++++++++--------
>  1 file changed, 52 insertions(+), 17 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt