linux-kernel - Re: [PATCH v4 10/14] arm64: Add KHO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1e59928-b2f4-47d4-87b8-424234c52f8d@kernel.org>
Date: Sun, 9 Feb 2025 11:38:37 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mike Rapoport <rppt@...nel.org>, linux-kernel@...r.kernel.org
Cc: Alexander Graf <graf@...zon.com>,
 Andrew Morton <akpm@...ux-foundation.org>, Andy Lutomirski
 <luto@...nel.org>, Anthony Yznaga <anthony.yznaga@...cle.com>,
 Arnd Bergmann <arnd@...db.de>, Ashish Kalra <ashish.kalra@....com>,
 Benjamin Herrenschmidt <benh@...nel.crashing.org>,
 Borislav Petkov <bp@...en8.de>, Catalin Marinas <catalin.marinas@....com>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 David Woodhouse <dwmw2@...radead.org>, Eric Biederman
 <ebiederm@...ssion.com>, Ingo Molnar <mingo@...hat.com>,
 James Gowans <jgowans@...zon.com>, Jonathan Corbet <corbet@....net>,
 Mark Rutland <mark.rutland@....com>, Paolo Bonzini <pbonzini@...hat.com>,
 Pasha Tatashin <pasha.tatashin@...een.com>, "H. Peter Anvin"
 <hpa@...or.com>, Peter Zijlstra <peterz@...radead.org>,
 Pratyush Yadav <ptyadav@...zon.de>, Rob Herring <robh+dt@...nel.org>,
 Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>,
 Stanislav Kinsburskii <skinsburskii@...ux.microsoft.com>,
 Steven Rostedt <rostedt@...dmis.org>, Thomas Gleixner <tglx@...utronix.de>,
 Tom Lendacky <thomas.lendacky@....com>, Usama Arif
 <usama.arif@...edance.com>, Will Deacon <will@...nel.org>,
 devicetree@...r.kernel.org, kexec@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-doc@...r.kernel.org,
 linux-mm@...ck.org, x86@...nel.org
Subject: Re: [PATCH v4 10/14] arm64: Add KHO support

On 06/02/2025 14:27, Mike Rapoport wrote:
> From: Alexander Graf <graf@...zon.com>
> 
> We now have all bits in place to support KHO kexecs. This patch adds

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> awareness of KHO in the kexec file as well as boot path for arm64 and
> adds the respective kconfig option to the architecture so that it can
> use KHO successfully.
> 
> Signed-off-by: Alexander Graf <graf@...zon.com>
> Co-developed-by: Mike Rapoport (Microsoft) <rppt@...nel.org>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@...nel.org>
> ---

...

> +#ifdef CONFIG_KEXEC_HANDOVER
> +	dt = image->kho.dt.buffer;
> +	dt_mem = image->kho.dt.mem;
> +	dt_len = image->kho.dt.bufsz;
> +
> +	scratch_mem = image->kho.scratch.mem;
> +	scratch_len = image->kho.scratch.bufsz;
> +#endif
> +
> +	if (!dt)
> +		goto out;
> +
> +	pr_debug("Adding kho metadata to DT");
> +
> +	ret = fdt_appendprop_addrrange(fdt, 0, chosen_node, "linux,kho-dt",

Where is the ABI documentation for this?

> +				       dt_mem, dt_len);
> +	if (ret)
> +		goto out;
> +
> +	ret = fdt_appendprop_addrrange(fdt, 0, chosen_node, "linux,kho-scratch",

Same question.

> +				       scratch_mem, scratch_len);
> +	if (ret)
> +		goto out;
> +
Best regards,
Krzysztof