linux-kernel - Re: [PATCH v6 0/5] Driver for pre-DCP apple display controller.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEg-Je_1Qe_q0Vt1ReX0HG83gNP3Ph37E+d_prDiMXSWtum5vQ@mail.gmail.com>
Date: Sun, 9 Feb 2025 06:01:51 -0500
From: Neal Gompa <neal@...pa.dev>
To: fnkl.kernel@...il.com
Cc: Hector Martin <marcan@...can.st>, Sven Peter <sven@...npeter.dev>, 
	Alyssa Rosenzweig <alyssa@...enzweig.io>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Neil Armstrong <neil.armstrong@...aro.org>, Jessica Zhang <quic_jesszhan@...cinc.com>, 
	asahi@...ts.linux.dev, Janne Grunau <j@...nau.net>, linux-arm-kernel@...ts.infradead.org, 
	dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Alyssa Ross <hi@...ssa.is>, 
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, Nick Chan <towinchenmi@...il.com>
Subject: Re: [PATCH v6 0/5] Driver for pre-DCP apple display controller.

On Thu, Feb 6, 2025 at 9:02 AM Sasha Finkelstein via B4 Relay
<devnull+fnkl.kernel.gmail.com@...nel.org> wrote:
>
> Hi.
>
> This patch series adds support for a secondary display controller
> present on Apple M1/M2 chips and used to drive the display of the
> "touchbar" touch panel present on those.
>
> Signed-off-by: Sasha Finkelstein <fnkl.kernel@...il.com>
> ---
> Changes in v6:
> - Use the drm_connector_helper_get_modes_fixed helper.
> - Split out into a separate MAINTAINERS entry
> - Link to v5: https://lore.kernel.org/r/20250205-adpdrm-v5-0-4e4ec979bbf2@gmail.com
>
> Changes in v5:
> - Moved to using the component framework.
> - Other lifetime fixes
> - Link to v4: https://lore.kernel.org/r/20250114-adpdrm-v4-0-e9b5260a39f1@gmail.com
>
> Changes in v4:
> - Fixed dt bindings.
> - Link to v3: https://lore.kernel.org/r/20250112-adpdrm-v3-0-c674dc19fa7f@gmail.com
>
> Changes in v3:
> - Fixed building as module after splitting out mipi block
> - Addressing the review feedback.
> - Link to v2: https://lore.kernel.org/r/20241126-adpdrm-v2-0-c90485336c09@gmail.com
>
> Changes in v2:
> - Addressing the review feedback.
> - Split out the mipi part of the display controller into a separate device
> - Link to v1: https://lore.kernel.org/r/20241124-adpdrm-v1-0-3191d8e6e49a@gmail.com
>
> ---
> Sasha Finkelstein (5):
>       dt-bindings: display: Add Apple pre-DCP display controller
>       drm: adp: Add Apple Display Pipe driver
>       drm: panel: Add a panel driver for the Summit display
>       arm64: dts: apple: Add touchbar screen nodes
>       MAINTAINERS: Add entries for touchbar display driver
>
>  .../display/apple,h7-display-pipe-mipi.yaml        |  83 +++
>  .../bindings/display/apple,h7-display-pipe.yaml    |  88 +++
>  .../bindings/display/panel/apple,summit.yaml       |  58 ++
>  MAINTAINERS                                        |  16 +
>  arch/arm64/boot/dts/apple/t8103-j293.dts           |  31 ++
>  arch/arm64/boot/dts/apple/t8103.dtsi               |  61 ++
>  arch/arm64/boot/dts/apple/t8112-j493.dts           |  31 ++
>  arch/arm64/boot/dts/apple/t8112.dtsi               |  61 ++
>  drivers/gpu/drm/Kconfig                            |   2 +
>  drivers/gpu/drm/Makefile                           |   1 +
>  drivers/gpu/drm/adp/Kconfig                        |  17 +
>  drivers/gpu/drm/adp/Makefile                       |   5 +
>  drivers/gpu/drm/adp/adp-mipi.c                     | 276 +++++++++
>  drivers/gpu/drm/adp/adp_drv.c                      | 617 +++++++++++++++++++++
>  drivers/gpu/drm/panel/Kconfig                      |   9 +
>  drivers/gpu/drm/panel/Makefile                     |   1 +
>  drivers/gpu/drm/panel/panel-summit.c               | 132 +++++
>  17 files changed, 1489 insertions(+)
> ---
> base-commit: b62cef9a5c673f1b8083159f5dc03c1c5daced2f
> change-id: 20241124-adpdrm-25fce3dd8a71
>

Series LGTM.

Reviewed-by: Neal Gompa <neal@...pa.dev>


-- 
真実はいつも一つ！/ Always, there's only one truth!