[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAEg-Je-iyYeJ3KrfmY5Rw7p9P4gJjFitfSQm6zU1YR+BaJ1z4Q@mail.gmail.com>
Date: Sun, 9 Feb 2025 06:15:30 -0500
From: Neal Gompa <neal@...pa.dev>
To: Nick Chan <towinchenmi@...il.com>
Cc: Hector Martin <marcan@...can.st>, Sven Peter <sven@...npeter.dev>,
Alyssa Rosenzweig <alyssa@...enzweig.io>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, asahi@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Janne Grunau <j@...nau.net>
Subject: Re: [PATCH v7 RESEND 00/11] Add PMGR nodes for Apple A7-A11, T2 SoCs
On Mon, Feb 3, 2025 at 7:20 AM Nick Chan <towinchenmi@...il.com> wrote:
>
> This series adds the PMGR nodes and all known power state subnodes for
> Apple A7-A11, T2 SoCs, along with the associated dt-bindings.
>
> Dependencies:
> - Split s8000/s8003 SoC DTS files
> https://lore.kernel.org/asahi/20250203113949.14760-1-towinchenmi@gmail.com/T
>
> - Device Tree for Apple T2 (T8012) devices.
> https://lore.kernel.org/asahi/20250203114417.16453-1-towinchenmi@gmail.com/T
>
> Changes since v6:
> - Now arch/arm64/boot/dts/apple/s800-0-3.dtsi builds, somehow this went
> under the radar this whole time...
>
> Link to v6: https://lore.kernel.org/asahi/20241222173750.148071-2-towinchenmi@gmail.com/T
>
> Changes since v5:
> - Rebase the series such that splitting s8000/s8003 device trees is the
> first patch to be applied. Now this series depends on Apple A9 device
> tree being split, and the T2 SoC PMGR nodes are added in this series.
>
> Link to v5: https://lore.kernel.org/asahi/20241203050640.109378-1-towinchenmi@gmail.com/T
>
> Changes since v4:
> - Use imperative mood in commit messages.
>
> Link to v4: https://lore.kernel.org/asahi/20241201161942.36027-1-towinchenmi@gmail.com/T
>
> Changes since v3:
> - Add "apple,always-on" property to "ps_spmi" in t8015 power domains.
> This is required for cpufreq to function correctly which will be added
> in a later series.
>
> Link to v3: https://lore.kernel.org/asahi/20241122095136.35046-1-towinchenmi@gmail.com/T
>
> Changes since v2:
> - Removed "apple,always-on" property from "ps_pmp" from s8001, t8011,
> t8015 power domains. It is not on at boot. (Mixed up with ps_pms which
> is required to be on)
> - Add asahi-soc/dt back into the subject prefix, missing from v2.
>
> Link to v2: https://lore.kernel.org/asahi/20241102011004.59339-1-towinchenmi@gmail.com/T
>
> Changes since v1:
> - Removed "framebuffer0" dt aliases. It is not standard and not needed.
>
> Link to v1: https://lore.kernel.org/asahi/20241029010526.42052-1-towinchenmi@gmail.com/T
>
> Nick Chan
> ---
>
> Nick Chan (11):
> dt-bindings: arm: apple: apple,pmgr: Add A7-A11, T2 compatibles
> dt-bindings: arm: apple: apple,pmgr-pwrstate: Add A7-A11, T2
> compatibles
> arm64: dts: apple: s5l8960x: Add PMGR node
> arm64: dts: apple: t7000: Add PMGR node
> arm64: dts: apple: t7001: Add PMGR node
> arm64: dts: apple: s800-0-3: Add PMGR nodes
> arm64: dts: apple: s8001: Add PMGR nodes
> arm64: dts: apple: t8010: Add PMGR nodes
> arm64: dts: apple: t8011: Add PMGR nodes
> arm64: dts: apple: t8012: Add PMGR nodes
> arm64: dts: apple: t8015: Add PMGR nodes
>
> .../bindings/arm/apple/apple,pmgr.yaml | 5 +
> .../bindings/power/apple,pmgr-pwrstate.yaml | 5 +
> arch/arm64/boot/dts/apple/s5l8960x-5s.dtsi | 4 +
> arch/arm64/boot/dts/apple/s5l8960x-air1.dtsi | 4 +
> arch/arm64/boot/dts/apple/s5l8960x-mini2.dtsi | 4 +
> arch/arm64/boot/dts/apple/s5l8960x-pmgr.dtsi | 610 ++++++++++++
> arch/arm64/boot/dts/apple/s5l8960x.dtsi | 13 +
> arch/arm64/boot/dts/apple/s800-0-3-pmgr.dtsi | 757 ++++++++++++++
> arch/arm64/boot/dts/apple/s800-0-3.dtsi | 22 +
> arch/arm64/boot/dts/apple/s8001-common.dtsi | 1 +
> .../arm64/boot/dts/apple/s8001-j98a-j99a.dtsi | 26 +
> arch/arm64/boot/dts/apple/s8001-j98a.dts | 1 +
> arch/arm64/boot/dts/apple/s8001-j99a.dts | 1 +
> arch/arm64/boot/dts/apple/s8001-pmgr.dtsi | 822 ++++++++++++++++
> arch/arm64/boot/dts/apple/s8001.dtsi | 22 +
> arch/arm64/boot/dts/apple/s800x-6s.dtsi | 4 +
> arch/arm64/boot/dts/apple/s800x-ipad5.dtsi | 4 +
> arch/arm64/boot/dts/apple/s800x-se.dtsi | 4 +
> arch/arm64/boot/dts/apple/t7000-6.dtsi | 4 +
> arch/arm64/boot/dts/apple/t7000-j42d.dts | 1 +
> arch/arm64/boot/dts/apple/t7000-mini4.dtsi | 4 +
> arch/arm64/boot/dts/apple/t7000-n102.dts | 4 +
> arch/arm64/boot/dts/apple/t7000-pmgr.dtsi | 641 ++++++++++++
> arch/arm64/boot/dts/apple/t7000.dtsi | 14 +
> arch/arm64/boot/dts/apple/t7001-air2.dtsi | 1 +
> arch/arm64/boot/dts/apple/t7001-pmgr.dtsi | 650 ++++++++++++
> arch/arm64/boot/dts/apple/t7001.dtsi | 13 +
> arch/arm64/boot/dts/apple/t8010-7.dtsi | 4 +
> arch/arm64/boot/dts/apple/t8010-ipad6.dtsi | 4 +
> arch/arm64/boot/dts/apple/t8010-n112.dts | 4 +
> arch/arm64/boot/dts/apple/t8010-pmgr.dtsi | 772 +++++++++++++++
> arch/arm64/boot/dts/apple/t8010.dtsi | 22 +
> arch/arm64/boot/dts/apple/t8011-common.dtsi | 1 +
> arch/arm64/boot/dts/apple/t8011-pmgr.dtsi | 806 +++++++++++++++
> arch/arm64/boot/dts/apple/t8011-pro2.dtsi | 8 +
> arch/arm64/boot/dts/apple/t8011.dtsi | 22 +
> arch/arm64/boot/dts/apple/t8012-pmgr.dtsi | 837 ++++++++++++++++
> arch/arm64/boot/dts/apple/t8012-touchbar.dtsi | 1 +
> arch/arm64/boot/dts/apple/t8012.dtsi | 22 +
> arch/arm64/boot/dts/apple/t8015-common.dtsi | 1 +
> arch/arm64/boot/dts/apple/t8015-pmgr.dtsi | 931 ++++++++++++++++++
> arch/arm64/boot/dts/apple/t8015.dtsi | 21 +
> 42 files changed, 7097 insertions(+)
> create mode 100644 arch/arm64/boot/dts/apple/s5l8960x-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/s800-0-3-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/s8001-j98a-j99a.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/s8001-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/t7000-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/t7001-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/t8010-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/t8011-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/t8012-pmgr.dtsi
> create mode 100644 arch/arm64/boot/dts/apple/t8015-pmgr.dtsi
>
>
> base-commit: 146773acdbf5afd40b0faf7383061a95adee8a2f
> --
> 2.48.1
>
>
Series looks good to me, so...
Reviewed-by: Neal Gompa <neal@...pa.dev>
I've also looped in the new Apple ARM maintainer Janne so they see the
patch set.
--
真実はいつも一つ!/ Always, there's only one truth!
Powered by blists - more mailing lists