linux-kernel - Re: [PATCH] lib/crc-t10dif: remove crc_t10dif_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXFt9d2vmNOaYk9+3CpEv9ZfTPTrDGgTKYOe-RCRgg7UFA@mail.gmail.com>
Date: Sun, 9 Feb 2025 12:52:38 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org, 
	Zhihang Shao <zhihang.shao.iscas@...il.com>
Subject: Re: [PATCH] lib/crc-t10dif: remove crc_t10dif_is_optimized()

On Sat, 8 Feb 2025 at 18:57, Eric Biggers <ebiggers@...nel.org> wrote:
>
> From: Eric Biggers <ebiggers@...gle.com>
>
> With the "crct10dif" algorithm having been removed from the crypto API,
> crc_t10dif_is_optimized() is no longer used.
>
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
>
> This applies to
> https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=crc-next
>
>  arch/arm/lib/crc-t10dif-glue.c     | 6 ------
>  arch/arm64/lib/crc-t10dif-glue.c   | 6 ------
>  arch/powerpc/lib/crc-t10dif-glue.c | 6 ------
>  arch/x86/lib/crc-t10dif-glue.c     | 6 ------
>  include/linux/crc-t10dif.h         | 9 ---------
>  5 files changed, 33 deletions(-)
>

Acked-by: Ard Biesheuvel <ardb@...nel.org>

> diff --git a/arch/arm/lib/crc-t10dif-glue.c b/arch/arm/lib/crc-t10dif-glue.c
> index d24dee62670e..f3584ba70e57 100644
> --- a/arch/arm/lib/crc-t10dif-glue.c
> +++ b/arch/arm/lib/crc-t10dif-glue.c
> @@ -67,14 +67,8 @@ arch_initcall(crc_t10dif_arm_init);
>  static void __exit crc_t10dif_arm_exit(void)
>  {
>  }
>  module_exit(crc_t10dif_arm_exit);
>
> -bool crc_t10dif_is_optimized(void)
> -{
> -       return static_key_enabled(&have_neon);
> -}
> -EXPORT_SYMBOL(crc_t10dif_is_optimized);
> -
>  MODULE_AUTHOR("Ard Biesheuvel <ard.biesheuvel@...aro.org>");
>  MODULE_DESCRIPTION("Accelerated CRC-T10DIF using ARM NEON and Crypto Extensions");
>  MODULE_LICENSE("GPL v2");
> diff --git a/arch/arm64/lib/crc-t10dif-glue.c b/arch/arm64/lib/crc-t10dif-glue.c
> index dab7e3796232..a007d0c5f3fe 100644
> --- a/arch/arm64/lib/crc-t10dif-glue.c
> +++ b/arch/arm64/lib/crc-t10dif-glue.c
> @@ -68,14 +68,8 @@ arch_initcall(crc_t10dif_arm64_init);
>  static void __exit crc_t10dif_arm64_exit(void)
>  {
>  }
>  module_exit(crc_t10dif_arm64_exit);
>
> -bool crc_t10dif_is_optimized(void)
> -{
> -       return static_key_enabled(&have_asimd);
> -}
> -EXPORT_SYMBOL(crc_t10dif_is_optimized);
> -
>  MODULE_AUTHOR("Ard Biesheuvel <ard.biesheuvel@...aro.org>");
>  MODULE_DESCRIPTION("CRC-T10DIF using arm64 NEON and Crypto Extensions");
>  MODULE_LICENSE("GPL v2");
> diff --git a/arch/powerpc/lib/crc-t10dif-glue.c b/arch/powerpc/lib/crc-t10dif-glue.c
> index 730850dbc51d..f411b0120cc5 100644
> --- a/arch/powerpc/lib/crc-t10dif-glue.c
> +++ b/arch/powerpc/lib/crc-t10dif-glue.c
> @@ -76,14 +76,8 @@ arch_initcall(crc_t10dif_powerpc_init);
>  static void __exit crc_t10dif_powerpc_exit(void)
>  {
>  }
>  module_exit(crc_t10dif_powerpc_exit);
>
> -bool crc_t10dif_is_optimized(void)
> -{
> -       return static_key_enabled(&have_vec_crypto);
> -}
> -EXPORT_SYMBOL(crc_t10dif_is_optimized);
> -
>  MODULE_AUTHOR("Daniel Axtens <dja@...ens.net>");
>  MODULE_DESCRIPTION("CRCT10DIF using vector polynomial multiply-sum instructions");
>  MODULE_LICENSE("GPL");
> diff --git a/arch/x86/lib/crc-t10dif-glue.c b/arch/x86/lib/crc-t10dif-glue.c
> index 13f07ddc9122..7734bdbc2e39 100644
> --- a/arch/x86/lib/crc-t10dif-glue.c
> +++ b/arch/x86/lib/crc-t10dif-glue.c
> @@ -39,13 +39,7 @@ arch_initcall(crc_t10dif_x86_init);
>  static void __exit crc_t10dif_x86_exit(void)
>  {
>  }
>  module_exit(crc_t10dif_x86_exit);
>
> -bool crc_t10dif_is_optimized(void)
> -{
> -       return static_key_enabled(&have_pclmulqdq);
> -}
> -EXPORT_SYMBOL(crc_t10dif_is_optimized);
> -
>  MODULE_DESCRIPTION("CRC-T10DIF using PCLMULQDQ instructions");
>  MODULE_LICENSE("GPL");
> diff --git a/include/linux/crc-t10dif.h b/include/linux/crc-t10dif.h
> index d0706544fc11..a559fdff3f7e 100644
> --- a/include/linux/crc-t10dif.h
> +++ b/include/linux/crc-t10dif.h
> @@ -17,15 +17,6 @@ static inline u16 crc_t10dif_update(u16 crc, const u8 *p, size_t len)
>  static inline u16 crc_t10dif(const u8 *p, size_t len)
>  {
>         return crc_t10dif_update(0, p, len);
>  }
>
> -#if IS_ENABLED(CONFIG_CRC_T10DIF_ARCH)
> -bool crc_t10dif_is_optimized(void);
> -#else
> -static inline bool crc_t10dif_is_optimized(void)
> -{
> -       return false;
> -}
> -#endif
> -
>  #endif
>
> base-commit: 3dceb9c4f1202d2c374976936ef803bf4b076fa7
> --
> 2.48.1
>