linux-kernel - Re: [PATCH] dmaengine: qcom: bam_dma: Avoid accessing BAM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cc3639f-2689-4e4a-a89b-02ade0efe966@ixit.cz>
Date: Sun, 9 Feb 2025 16:19:53 +0100
From: David Heidelberg <david@...t.cz>
To: bjorn.andersson@....qualcomm.com
Cc: djakov@...nel.org, dmaengine@...r.kernel.org,
 dmitry.baryshkov@...aro.org, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org, quic_mdalam@...cinc.com, vkoul@...nel.org
Subject: Re: [PATCH] dmaengine: qcom: bam_dma: Avoid accessing BAM_REVISION on
 remote BAM

On 7.02.25 22:17, Bjorn Andersson wrote:
 > Commit '57a7138d0627 ("dmaengine: qcom: bam_dma: Avoid writing
 > unavailable register")' made this read unconditional, in order to
 > identify if the instance is BAM-NDP or BAM-Lite.
 > But the BAM_REVISION register is not accessible on remotely managed BAM
 > instances and attempts to access it causes the system to crash.
 >
 > Move the access back to be conditional and expand the checks that was
 > introduced to restore the old behavior when no revision information is
 > available.
 >
 > Fixes: 57a7138d0627 ("dmaengine: qcom: bam_dma: Avoid writing 
unavailable register")
 > Reported-by: Georgi Djakov <djakov@...nel.org>
 > Closes: 
https://lore.kernel.org/lkml/9ef3daa8-cdb1-49f2-8d19-a72d6210ff3a@kernel.org/
 > Signed-off-by: Bjorn Andersson <bjorn.andersson@....qualcomm.com>

Tested-by: David Heidelberg <david@...t.cz> # OnePlus 6T

-- 
David Heidelberg