linux-kernel - Re: [PATCH RFC 2/3] dt-bindings: mmc: brcm,sdhci-brcmstb: Add sdio sharing support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12c1fb05-6cf5-4fb3-9db8-730bc7f6cfc7@kernel.org>
Date: Sun, 9 Feb 2025 17:30:52 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kamal Dasu <kamal.dasu@...adcom.com>, ulf.hansson@...aro.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 adrian.hunter@...el.com, linux-mmc@...r.kernel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, wsa+renesas@...g-engineering.com
Cc: f.fainelli@...il.com, bcm-kernel-feedback-list@...adcom.com,
 Kamal Dasu <kdasu@...adcom.com>
Subject: Re: [PATCH RFC 2/3] dt-bindings: mmc: brcm,sdhci-brcmstb: Add sdio
 sharing support

On 06/02/2025 23:09, Kamal Dasu wrote:
> From: Kamal Dasu <kdasu@...adcom.com>
> 
> Introduce emmc flash sharing support using hardware semaphore
> and SDIO share register to synchronize between TZOS and linux.
> 
> Signed-off-by: Kamal Dasu <kdasu@...adcom.com>

It's RFC, so I assume you do not expect review and then you can skip
this and obviously it is also NAK for the patch (so maintainers won't
take it).

However if you actually expect review, then:

> ---
>  .../bindings/mmc/brcm,sdhci-brcmstb.yaml         | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> index eee6be7a7867..b0ee39aeccb1 100644
> --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> @@ -27,15 +27,23 @@ properties:
>            - const: brcm,sdhci-brcmstb
>  
>    reg:
> -    maxItems: 2
> +    minItems: 2

1. Missing constraint
2. Please follow DTS coding style
3. and finally this needs to be tested, so:

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>

Best regards,
Krzysztof