linux-kernel - Re: [PATCH] scripts: generate_rust_analyzer.py: add missing macros -> core dep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72n+w9exRE=HHDsiOtf_O-nB1LOxiWnfoVoinmaWgGFQbg@mail.gmail.com>
Date: Sun, 9 Feb 2025 18:21:36 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Tamir Duberstein <tamird@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Boris-Chengbiao Zhou <bobo1239@....de>, Fiona Behrens <me@...enk.dev>, Kees Cook <kees@...nel.org>, 
	Wedson Almeida Filho <wedsonaf@...gle.com>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Chayim Refael Friedman <chayimfr@...il.com>, 
	Lukas Wirth <lukas.wirth@...rous-systems.com>, 
	Daniel Almeida <daniel.almeida@...labora.com>
Subject: Re: [PATCH] scripts: generate_rust_analyzer.py: add missing macros ->
 core dep

On Sun, Feb 9, 2025 at 6:09 PM Tamir Duberstein <tamird@...il.com> wrote:
>
> The detailed reason why splitting host and target crates requires
> refactoring is that we currently we use `display_name` as a crate's
> unique identifier (i.e. both as a way of naming it as another crate's
> dependency, and as its name in the dependent crate). If we wanted to
> have separate target and host `core` crates we'd need a slightly more
> sophisticated way of describing dependencies. I'll work on this in a
> separate series.

Yeah, that is why I was wondering if it would be worth it or not, and
why I asked Lukas et al. (who leads rust-analyzer) if rust-analyzer is
OK with that to begin with (or what is the expected way to do this),
i.e. it may be that rust-analyzer does not "like" several crates with
the same `display_name`.

In any case, I would like to keep the complexity of the script low if
possible unless it really makes rust-analyzer understand the code
better etc.

Thanks!

Cheers,
Miguel