linux-kernel - Re: [PATCH v1 08/13] iommufd/device: Move sw_msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250209184152.GM3660748@nvidia.com>
Date: Sun, 9 Feb 2025 14:41:52 -0400
From: Jason Gunthorpe <jgg@...dia.com>
To: Nicolin Chen <nicolinc@...dia.com>
Cc: kevin.tian@...el.com, tglx@...utronix.de, maz@...nel.org,
	joro@...tes.org, will@...nel.org, robin.murphy@....com,
	shuah@...nel.org, iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kselftest@...r.kernel.org, eric.auger@...hat.com,
	baolu.lu@...ux.intel.com, yi.l.liu@...el.com, yury.norov@...il.com,
	jacob.pan@...ux.microsoft.com, patches@...ts.linux.dev
Subject: Re: [PATCH v1 08/13] iommufd/device: Move sw_msi_start from igroup
 to idev

On Sat, Feb 08, 2025 at 01:02:41AM -0800, Nicolin Chen wrote:
> @@ -433,8 +433,8 @@ static int iommufd_group_setup_msi(struct iommufd_group *igroup,
>  	list_for_each_entry(cur, &ictx->sw_msi_list, sw_msi_item) {
>  		int rc;
>  
> -		if (cur->sw_msi_start != igroup->sw_msi_start ||
> -		    !test_bit(cur->id, igroup->required_sw_msi.bitmap))
> +		if (cur->sw_msi_start != idev->sw_msi_start ||
> +		    !test_bit(cur->id, idev->igroup->required_sw_msi.bitmap))
>  			continue;

So we end up creating seperate sw_msi_list items with unique IDs for
every sw_msi_start?

That indeed might work well, I will try to check it and think about
this harder.

Jason