linux-kernel - Re: [PATCH] mtd: rawnand: qcom: finish converting register to FIELD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877c5xu8yt.fsf@bootlin.com>
Date: Mon, 10 Feb 2025 16:15:38 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,  Richard
 Weinberger <richard@....at>,  Vignesh Raghavendra <vigneshr@...com>,
  linux-mtd@...ts.infradead.org,  linux-arm-msm@...r.kernel.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: rawnand: qcom: finish converting register to
 FIELD_PREP

Hello Christian,

On 09/02/2025 at 15:54:32 +01, Christian Marangi <ansuelsmth@...il.com> wrote:

> With some research in some obscure old QSDK, it was possible to find the
> MASK of the last register there were still set with raw shift and
> convert them to FIELD_PREP API.
>
> This is only a cleanup and modernize the code a bit and doesn't make
> any behaviour change.
>
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> ---
>  drivers/mtd/nand/raw/qcom_nandc.c    | 36 ++++++++++++++--------------

I'm fine with your two patches. I was about to apply them, but the first
one needs to go through fixes, whereas the second through next, and they
are dependent on each other. I propose the following modification:
- create patch 1/2 with the content of the cleanup done just below, but
  only adapted to the very specific spot that is touched by the fix "fix
  broken config...". It would be a prerequisite for the fix.
- patch 2/2 would be the content of "fix broken config..."

And aside, a totally independent patch easy to apply on -rc1 with the
rest of this patch.

Would that work for you?

Thanks,
Miquèl