linux-kernel - Re: [PATCH] drm/bridge: analogix_dp: Use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAN6tsi4xwkfZgmJimDvoWUNY0qXJDAhzfXsKG5zcdGN_yv7pZg@mail.gmail.com>
Date: Mon, 10 Feb 2025 16:16:53 +0100
From: Robert Foss <rfoss@...nel.org>
To: oushixiong1025@....com
Cc: Andrzej Hajda <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Laurent Pinchart <Laurent.pinchart@...asonboard.com>, Jonas Karlman <jonas@...boo.se>, 
	Jernej Skrabec <jernej.skrabec@...il.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	Shixiong Ou <oushixiong@...inos.cn>
Subject: Re: [PATCH] drm/bridge: analogix_dp: Use devm_platform_ioremap_resource()

On Tue, Jan 28, 2025 at 7:57 AM <oushixiong1025@....com> wrote:
>
> From: Shixiong Ou <oushixiong@...inos.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_ioremap_resource().
>
> Signed-off-by: Shixiong Ou <oushixiong@...inos.cn>
> ---
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index bfa88409a7ff..f6e4bdc05ba0 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1553,7 +1553,6 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
>  {
>         struct platform_device *pdev = to_platform_device(dev);
>         struct analogix_dp_device *dp;
> -       struct resource *res;
>         unsigned int irq_flags;
>         int ret;
>
> @@ -1605,9 +1604,7 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data)
>                 return ERR_CAST(dp->clock);
>         }
>
> -       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> -       dp->reg_base = devm_ioremap_resource(&pdev->dev, res);
> +       dp->reg_base = devm_platform_ioremap_resource(pdev, 0);
>         if (IS_ERR(dp->reg_base)) {
>                 ret = PTR_ERR(dp->reg_base);
>                 goto err_disable_clk;
> --
> 2.43.0
>

Reviewed-by: Robert Foss <rfoss@...nel.org>