linux-kernel - Re: [PATCH] acct: Prevent NULL pointer dereference when writing to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250210152146.GC1977892@ZenIV>
Date: Mon, 10 Feb 2025 15:21:46 +0000
From: Al Viro <viro@...iv.linux.org.uk>
To: Christian Brauner <brauner@...nel.org>
Cc: Zicheng Qu <quzicheng@...wei.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>, jlayton@...nel.org,
	axboe@...nel.dk, joel.granados@...nel.org, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, hch@....de, len.brown@...el.com,
	pavel@....cz, pengfei.xu@...el.com, rafael@...nel.org,
	syzkaller-bugs@...glegroups.com, linux-pm@...r.kernel.org,
	tanghui20@...wei.com, zhangqiao22@...wei.com,
	judy.chenhui@...wei.com
Subject: Re: [PATCH] acct: Prevent NULL pointer dereference when writing to
 sysfs

On Mon, Feb 10, 2025 at 04:12:54PM +0100, Christian Brauner wrote:

> One fix would be to move exit_fs() past exit_task_work(). It looks like
> that this should be doable without much of a problem and it would fix
> the path_init() problem.
> 
> There should hopefully be nothing relying on task->fs == NULL in
> exit_task_work().

There's a question of the task_work_add() issued by exit_task_fs(),
though.