linux-kernel - Re: [PATCH 5/5] hwmon: (gpio-fan) Add regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0c82f6dc-4f5b-4787-9e43-4990681ea6a2@sirena.org.uk>
Date: Mon, 10 Feb 2025 15:26:21 +0000
From: Mark Brown <broonie@...nel.org>
To: Alexander Stein <alexander.stein@...tq-group.com>
Cc: Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>, linux-hwmon@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] hwmon: (gpio-fan) Add regulator support

On Mon, Feb 10, 2025 at 03:59:33PM +0100, Alexander Stein wrote:

> +	fan_data->supply = devm_regulator_get_optional(dev, "fan");
> +	if (IS_ERR(fan_data->supply)) {
> +		err = PTR_ERR(fan_data->supply);

Unless fans are expected to operate without power (which does seem
unlikely) the supply should really be mandatory.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)