linux-kernel - Re: [PATCH v7 01/11] kconfig: Add PicoSAT interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6odTBbLvTTnaSII@bombadil.infradead.org>
Date: Mon, 10 Feb 2025 07:37:48 -0800
From: Luis Chamberlain <mcgrof@...nel.org>
To: Ole Schuerks <ole0811sch@...il.com>
Cc: linux-kbuild@...r.kernel.org, jude.gyimah@....de,
	thorsten.berger@....de, deltaone@...ian.org, jan.sollmann@....de,
	masahiroy@...nel.org, linux-kernel@...r.kernel.org,
	nathan@...nel.org, nicolas@...sle.eu
Subject: Re: [PATCH v7 01/11] kconfig: Add PicoSAT interface

On Sat, Feb 08, 2025 at 05:39:49PM +0100, Ole Schuerks wrote:
> +bool load_picosat(void)
> +{
> +	void *handle = NULL;
> +	bool failed = false;
> +
> +	/*
> +	 * Try different names for the .so library. This is necessary since
> +	 * all packages don't use the same versioning.
> +	 */
> +	for (int i = 0; i < ARRAY_SIZE(picosat_lib_names) && !handle; ++i)
> +		handle = dlopen(picosat_lib_names[i], RTLD_LAZY);
> +	if (!handle) {
> +		printd("%s\n", dlerror());
> +		return false;
> +	}

This will only detect an error if the last dlopen() failed.

Other than that:

Reviewed-by: Luis Chamberlain <mcgrof@...nel.org>

 Luis