linux-kernel - Re: [PATCH] accel/amdxdna: Add missing include linux/slab.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0db60138-2e9b-1ccb-9c0e-1b781f19ebd6@amd.com>
Date: Mon, 10 Feb 2025 08:28:38 -0800
From: Lizhi Hou <lizhi.hou@....com>
To: Su Hui <suhui@...china.com>, <min.ma@....com>, <ogabbay@...nel.org>
CC: <quic_jhugo@...cinc.com>, <George.Yang@....com>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] accel/amdxdna: Add missing include linux/slab.h


On 2/8/25 00:05, Su Hui wrote:
> When compiling without CONFIG_IA32_EMULATION, there are some errors:
>
> drivers/accel/amdxdna/amdxdna_mailbox.c: In function ‘mailbox_release_msg’:
> drivers/accel/amdxdna/amdxdna_mailbox.c:197:2: error: implicit declaration
> of function ‘kfree’.
>    197 |  kfree(mb_msg);
>        |  ^~~~~
> drivers/accel/amdxdna/amdxdna_mailbox.c: In function ‘xdna_mailbox_send_msg’:
> drivers/accel/amdxdna/amdxdna_mailbox.c:418:11: error:implicit declaration
> of function ‘kzalloc’.
>    418 |  mb_msg = kzalloc(sizeof(*mb_msg) + pkg_size, GFP_KERNEL);
>        |           ^~~~~~~
>
> Add the missing include.
>
> Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
> Signed-off-by: Su Hui <suhui@...china.com>
> ---
>   drivers/accel/amdxdna/amdxdna_mailbox.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c
> index 814b16bb1953..80b4b20addd6 100644
> --- a/drivers/accel/amdxdna/amdxdna_mailbox.c
> +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
> @@ -12,6 +12,7 @@
>   
>   #define CREATE_TRACE_POINTS
>   #include <trace/events/amdxdna.h>
> +#include <linux/slab.h>
Reviewed-by: Lizhi Hou <lizhi.hou@....com>
>   
>   #include "amdxdna_mailbox.h"
>