linux-kernel - Re: [PATCH v2] kdb: remove usage of static environment buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=UCiGuwuVatoviUvYPeBFkfiWm+oWaiQRG_1U-j6LGGGA@mail.gmail.com>
Date: Mon, 10 Feb 2025 08:30:13 -0800
From: Doug Anderson <dianders@...omium.org>
To: Nir Lichtman <nir@...htman.org>
Cc: jason.wessel@...driver.com, danielt@...nel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] kdb: remove usage of static environment buffer

Hi,

On Mon, Feb 3, 2025 at 9:47 PM Nir Lichtman <nir@...htman.org> wrote:
>
> Problem: The set environment variable logic uses a static "heap" like
> buffer to store the values of the variables, and they are never freed,
> on top of that this is redundant since the kernel supplies allocation
> facilities which are even used also in this file.
>
> Solution: Remove the weird static buffer logic and use kmalloc instead,
> call kfree when overriding an existing variable.
>
> Signed-off-by: Nir Lichtman <nir@...htman.org>
> ---
>
> v2: Fixes following Doug's CR - use kmalloc_const instead of kmalloc &
> rm redundant print in case of allocation error
>
>  include/linux/kdb.h         |  2 +-
>  kernel/debug/kdb/kdb_main.c | 48 +++++++------------------------------
>  2 files changed, 9 insertions(+), 41 deletions(-)

Reviewed-by: Douglas Anderson <dianders@...omium.org>