linux-kernel - Re: [PATCH v4 2/9] rust/kernel: Add faux device bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c00ee85d-8e8f-4d59-9c90-af5fd35cc4ac@proton.me>
Date: Mon, 10 Feb 2025 16:32:15 +0000
From: Benno Lossin <benno.lossin@...ton.me>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org, Lyude Paul <lyude@...hat.com>, "Rafael J. Wysocki" <rafael@...nel.org>, Danilo Krummrich <dakr@...nel.org>
Cc: Alexander Lobakin <aleksander.lobakin@...el.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Bjorn Helgaas <bhelgaas@...gle.com>, Jonathan Cameron <Jonathan.Cameron@...wei.com>, Liam Girdwood <lgirdwood@...il.com>, Lukas Wunner <lukas@...ner.de>, Mark Brown <broonie@...nel.org>, Maíra Canal <mairacanal@...eup.net>, Robin Murphy <robin.murphy@....com>, Simona Vetter <simona.vetter@...ll.ch>, Zijun Hu <quic_zijuhu@...cinc.com>, linux-usb@...r.kernel.org, rust-for-linux@...r.kernel.org, Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Subject: Re: [PATCH v4 2/9] rust/kernel: Add faux device bindings

On 10.02.25 13:30, Greg Kroah-Hartman wrote:
> From: Lyude Paul <lyude@...hat.com>
> 
> This introduces a module for working with faux devices in rust, along with
> adding sample code to show how the API is used. Unlike other types of
> devices, we don't provide any hooks for device probe/removal - since these
> are optional for the faux API and are unnecessary in rust.

For me it would be useful to know why this is the case. I looked at the
dummy regulator driver and it still has a `probe` function. Presumably,
because it has to wait until other resources are usable and that is the
case once `probe` gets called. But doesn't the same hold for Rust? Or
are Rust modules loaded later than C modules? Because if I were to
rewrite the regulator driver in Rust (assuming we had the abstractions),
the `probe` code would be put into the `Module::init` function, right?
Or am I missing something?

Thanks!
Benno