linux-kernel - Re: [PATCH v5 2/2] scanf: break kunit into test cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ-ks9nJ6t4UZuH1fOHG5bU0dx5Pcm8XiPUw0c9off+kP2Y1XA@mail.gmail.com>
Date: Mon, 10 Feb 2025 11:35:35 -0500
From: Tamir Duberstein <tamird@...il.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: David Gow <davidgow@...gle.com>, Petr Mladek <pmladek@...e.com>, 
	Steven Rostedt <rostedt@...dmis.org>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
	Rasmus Villemoes <linux@...musvillemoes.dk>, Sergey Senozhatsky <senozhatsky@...omium.org>, 
	Andrew Morton <akpm@...ux-foundation.org>, Shuah Khan <shuah@...nel.org>, 
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v5 2/2] scanf: break kunit into test cases

On Mon, Feb 10, 2025 at 11:27 AM Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
>
> > [...]
> >
> > -static char *test_buffer;
> > -static char *fmt_buffer;
> > +static char test_buffer[BUF_SIZE];
> > +static char fmt_buffer[BUF_SIZE];
>
> Why? This wastes 2 KiB of memory when the test is not running.

It's a fair point. I guess I'll respin v6 after all and go back to kmalloc.

Thanks for reviewing!