lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <874j11buqv.fsf@kloenk.dev>
Date: Mon, 10 Feb 2025 18:00:08 +0100
From: Fiona Behrens <me@...enk.dev>
To: Tamir Duberstein <tamird@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>,  Alex Gaynor <alex.gaynor@...il.com>,
  Boqun Feng <boqun.feng@...il.com>,  Gary Guo <gary@...yguo.net>,
  Björn
 Roy Baron <bjorn3_gh@...tonmail.com>,  Benno Lossin
 <benno.lossin@...ton.me>,  Andreas Hindborg <a.hindborg@...nel.org>,
  Alice Ryhl <aliceryhl@...gle.com>,  Trevor Gross <tmgross@...ch.edu>,
  Boris-Chengbiao Zhou <bobo1239@....de>,  Kees Cook <kees@...nel.org>,
  rust-for-linux@...r.kernel.org,  linux-kernel@...r.kernel.org,  Chayim
 Refael Friedman <chayimfr@...il.com>
Subject: Re: [PATCH v2] scripts: generate_rust_analyzer.py: add missing
 macros deps

Tamir Duberstein <tamird@...il.com> writes:

> On Mon, Feb 10, 2025 at 11:32 AM Fiona Behrens <me@...enk.dev> wrote:
>>
>> Competing with https://lore.kernel.org/rust-for-linux/20241205115438.234221-1-me@kloenk.dev/
>> but I do like your aproach more.
>
> Missed this one go by. Sorry!

No worries at all, was mostly also to make sure that not both gets merged.

>
>> Reviewed-by: Fiona Behrens <me@...enk.dev>
>
> Thanks for reviewing! I'm going to respin v3 that looks a little bit
> more like https://lore.kernel.org/all/20250209-rust-analyzer-host-v1-3-a2286a2a2fa3@gmail.com/
> which is the proper fix. If you're OK with it, I'll keep your tag.

Sure, feel also free to ping on zullip if anything specific before
sending. But your code already looks very good. Like it with the types
and such.

Thanks
Fiona

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ