linux-kernel - Re: [PATCH V5] phy: freescale: fsl-samsung-hdmi: fix build error in fsl_samsung_hdmi_phy_configure_pll_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6oxJEvABw780+DZ@vaman>
Date: Mon, 10 Feb 2025 22:32:28 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Pei Xiao <xiaopei01@...inos.cn>
Cc: xiaopeitux@...mail.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V5] phy: freescale: fsl-samsung-hdmi: fix build error in
 fsl_samsung_hdmi_phy_configure_pll_lock_det

On 17-01-25, 10:15, Pei Xiao wrote:
> 
> 在 2025/1/17 09:59, Adam Ford 写道:
> > On Mon, Jan 13, 2025 at 2:41 AM <xiaopeitux@...mail.com> wrote:
> >> From: Pei Xiao <xiaopei01@...inos.cn>
> >>
> >> FIELD_PREP() checks that a value fits into the available bitfield,
> >> but the index div equals to 4,is out of range.
> >>
> >> which gcc complains about:
> >> In function ‘fsl_samsung_hdmi_phy_configure_pll_lock_det’,
> >> inlined from ‘fsl_samsung_hdmi_phy_configure’ at
> >> drivers/phy/freescale/phy-fsl-samsung-hdmi.c :470:2:
> >> ././include/linux/compiler_types.h:542:38: error: call to ‘__compiletime_assert_538’
> >> declared with attribute error: FIELD_PREP: value too large for the field
> >>   542 |  _compiletime_assert(condition, msg, __compiletime_assert_,
> >> __COUNTER__)
> >>       |                                      ^
> >> ././include/linux/compiler_types.h:523:4: note: in definition of
> >> macro ‘__compiletime_assert’ 523 |    prefix ## suffix();
> >>       |    ^~~~~~
> >> ././include/linux/compiler_types.h:542:2: note: in expansion of macro
> >> ‘_compiletime_assert’
> >>   542 |  _compiletime_assert(condition, msg, __compiletime_assert_,
> >>  __COUNTER__)
> >>
> >> REG12_CK_DIV_MASK only two bit, limit div to range 0~3,
> >> so build error will fix.
> >>
> > LGTM.
> >
> > Reviewed-by:  Adam Ford <aford173@...il.com>
> loop Vkoul for email address was written incorrectly.

Thanks for looping in!

Change looks good to me. Can you please revise the patch title. A patch
title should describe the change we are making. Fix build error is not
an apt title

-- 
~Vinod