linux-kernel - Re: [PATCH v2 04/16] dt-bindings: clock: at91: Allow referencing main rc oscillator in DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89d51ac4-0690-42a7-b5fb-2887363e8a8b@kernel.org>
Date: Mon, 10 Feb 2025 18:07:10 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alexander Dahl <ada@...rsis.com>,
 Claudiu Beznea <claudiu.beznea@...on.dev>
Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>,
 Ryan Wanner <ryan.wanner@...rochip.com>,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v2 04/16] dt-bindings: clock: at91: Allow referencing main
 rc oscillator in DT

On 10/02/2025 17:44, Alexander Dahl wrote:
> The main rc oscillator will be needed for the OTPC to work properly.
> 
> The new index introduced here was not used on the four affected SoC
> clock drivers before, but for sama5d2 only (PMC_I2S1_MUX).
> 
> Link: https://lore.kernel.org/linux-devicetree/20250207-jailbird-circus-bcc04ee90e05@thorsis.com/T/#u
> Signed-off-by: Alexander Dahl <ada@...rsis.com>
> ---
> 
> Notes:
>     v2:
>     - new patch, not present in v1
> 
>  include/dt-bindings/clock/microchip,sam9x60-pmc.h  | 3 +++
>  include/dt-bindings/clock/microchip,sam9x7-pmc.h   | 3 +++
>  include/dt-bindings/clock/microchip,sama7d65-pmc.h | 3 +++
>  include/dt-bindings/clock/microchip,sama7g5-pmc.h  | 3 +++
>  4 files changed, 12 insertions(+)
> 
> diff --git a/include/dt-bindings/clock/microchip,sam9x60-pmc.h b/include/dt-bindings/clock/microchip,sam9x60-pmc.h
> index e01e867e8c4da..dcd3c74f75b54 100644
> --- a/include/dt-bindings/clock/microchip,sam9x60-pmc.h
> +++ b/include/dt-bindings/clock/microchip,sam9x60-pmc.h
> @@ -16,4 +16,7 @@
>  
>  #define SAM9X60_PMC_PLLACK	PMC_PLLACK	/* 7 */
>  
> +/* new from after bindings splitup */
> +#define SAM9X60_PMC_MAIN_RC	6

This is confusing me, because:
1. You still have holes in IDs
2. This should be placed in proper order by ID
3. Why not using 4 - the next available empty ID?

Best regards,
Krzysztof