linux-kernel - Re: [PATCH] selftests: tpm2: test_smoke: use POSIX-conformant expression operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D7OY3ZVGJOV5.R3SL9SBFT2DF@kernel.org>
Date: Mon, 10 Feb 2025 19:35:28 +0200
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "Ahmed Salem" <x0rw3ll@...il.com>, <peterhuewe@....de>, <jgg@...pe.ca>,
 <shuah@...nel.org>, <skhan@...uxfoundation.org>
Cc: <linux-integrity@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] selftests: tpm2: test_smoke: use POSIX-conformant
 expression operator

On Mon Feb 10, 2025 at 7:03 PM EET, Ahmed Salem wrote:
> test_smoke.sh:9: expression uses non POSIX-conformant operator
> symbol '==', resulting in skipping the remaining tests.
>
> This patch ensures the use of POSIX-conformant operator symbol '='.
>
> w/o this patch for test_smoke.sh
> ================================
> $ sudo make -j8 TARGETS=tpm2 kselftest
> make[3]: Nothing to be done for 'all'.
> TAP version 13
> 1..3
>  # timeout set to 600
>  # selftests: tpm2: test_smoke.sh
>  # ./test_smoke.sh: 9: [: 2: unexpected operator
> ok 1 selftests: tpm2: test_smoke.sh # SKIP

The fix is fine but cut out snippets of transcripts pinpointing
the issue.

BR, Jarkko