linux-kernel - Re: [PATCH v5] HID: corsair-void: Add Corsair Void headset family driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0bc098bf-6c02-4d62-bcb1-939e1f0b9f95@kernel.org>
Date: Mon, 10 Feb 2025 18:43:24 +0100
From: Jiri Slaby <jirislaby@...nel.org>
To: Stuart <stuart.a.hayhurst@...il.com>
Cc: linux-input@...r.kernel.org, Jiri Kosina <jikos@...nel.org>,
 Benjamin Tissoires <bentiss@...nel.org>,
 Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] HID: corsair-void: Add Corsair Void headset family
 driver

On 10. 02. 25, 17:15, Stuart wrote:
>> This effectively kills the system. We came here via:
>> corsair_void_raw_event (hid_driver::raw_event)
>>     -> corsair_void_process_receiver
>>       -> scoped_guard(mutex, &drvdata->battery_mutex)
> 
>> And hid_driver::raw_event can be called from the interrupt context. This
>> happened at:
> 
> Damn it, I was suspicious that it was too easy. It's been running for a year
> without an issue on my system, I'll clearly have to read a bit more.
> 
> I'm not sure what the best solution is for this.
> 'corsair_void_process_receiver()' shouldn't be called frequently, and
> the locks shouldn't be waiting on each other very often, so I suppose
> swapping the mutex for a spinlock is probably the best option, instead of
> increasing code complexity?

Not that easy, as AFAIR power unregister cannot sleep.

-- 
js
suse labs