linux-kernel - Re: [PATCH v8 01/17] spi: add basic support for SPI offloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1dcbb19-190a-45e7-8e94-cb5ef65f1f1b@sirena.org.uk>
Date: Mon, 10 Feb 2025 17:48:00 +0000
From: Mark Brown <broonie@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Andy Shevchenko <andriy.shevchenko@...el.com>,
	Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Nuno Sá <nuno.sa@...log.com>,
	Uwe Kleine-König <ukleinek@...nel.org>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	David Jander <david@...tonic.nl>,
	Martin Sperl <kernel@...tin.sperl.org>, linux-spi@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-iio@...r.kernel.org,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH v8 01/17] spi: add basic support for SPI offloading

On Mon, Feb 10, 2025 at 11:11:23AM -0600, David Lechner wrote:
> On 2/10/25 10:45 AM, Andy Shevchenko wrote:
> > On Fri, Feb 07, 2025 at 02:08:58PM -0600, David Lechner wrote:

> >> +MODULE_IMPORT_NS("SPI_OFFLOAD");

> > This diminishes the point of the namespaces. Anybody who includes a (dangling)
> > header gets namespace imported, which is not good. Same for other globally
> > visible headers.

> In this case, we specifically split up the headers so that the only time you
> would ever include this header is if you need to call functions in this
> namespace (i.e. struct definitions are in linux/spi/offload/types.h which
> doesn't import the namespace). So this doesn't actually seem like a problem
> to me.

Indeed - I can't see any case where a user would need the header without
needing the namespace.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)