linux-kernel - Re: [PATCH V1] PCI: tegra194: Add support for PCIe RC & EP in Tegra234 Platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250210175050.5htfgtgkyrfcjtre@thinkpad>
Date: Mon, 10 Feb 2025 23:20:50 +0530
From: "manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>
To: Vidya Sagar <vidyas@...dia.com>
Cc: Niklas Cassel <cassel@...nel.org>,
	"lpieralisi@...nel.org" <lpieralisi@...nel.org>,
	"kw@...ux.com" <kw@...ux.com>, "robh@...nel.org" <robh@...nel.org>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"quic_schintav@...cinc.com" <quic_schintav@...cinc.com>,
	"johan+linaro@...nel.org" <johan+linaro@...nel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Thierry Reding <treding@...dia.com>,
	Jon Hunter <jonathanh@...dia.com>,
	Krishna Thota <kthota@...dia.com>,
	Manikanta Maddireddy <mmaddireddy@...dia.com>,
	"sagar.tv@...il.com" <sagar.tv@...il.com>
Subject: Re: [PATCH V1] PCI: tegra194: Add support for PCIe RC & EP in
 Tegra234 Platforms

On Mon, Feb 10, 2025 at 02:25:43PM +0000, Vidya Sagar wrote:
> Thanks Niklas for the review.
> I'll rewrite the commit message add the following line
> Fixes: a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support")
> 

No, please. Try to use the generic ARCH symbol dependency as suggested.

- Mani

> Thanks
> Vidya Sagar
> 
> ________________________________
> From: Niklas Cassel <cassel@...nel.org>
> Sent: Tuesday, January 28, 2025 17:34
> To: Vidya Sagar <vidyas@...dia.com>
> Cc: lpieralisi@...nel.org <lpieralisi@...nel.org>; kw@...ux.com <kw@...ux.com>; manivannan.sadhasivam@...aro.org <manivannan.sadhasivam@...aro.org>; robh@...nel.org <robh@...nel.org>; bhelgaas@...gle.com <bhelgaas@...gle.com>; quic_schintav@...cinc.com <quic_schintav@...cinc.com>; johan+linaro@...nel.org <johan+linaro@...nel.org>; linux-pci@...r.kernel.org <linux-pci@...r.kernel.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>; Thierry Reding <treding@...dia.com>; Jon Hunter <jonathanh@...dia.com>; Krishna Thota <kthota@...dia.com>; Manikanta Maddireddy <mmaddireddy@...dia.com>; sagar.tv@...il.com <sagar.tv@...il.com>
> Subject: Re: [PATCH V1] PCI: tegra194: Add support for PCIe RC & EP in Tegra234 Platforms
> 
> External email: Use caution opening links or attachments
> 
> 
> Hello Vidya,
> 
> On Tue, Jan 28, 2025 at 10:12:44AM +0530, Vidya Sagar wrote:
> > Add PCIe RC & EP support for Tegra234 Platforms.
> 
> The commit log does leave quite a few questions unanswered.
> 
> Since you are just updating the Kconfig and nothing else:
> Does the DT binding already have support for the Tegra234 SoC?
> Does the driver already have support for the Tegra234 SoC?
> 
> Looking at the DT binding and driver, the answer to both questions
> is yes. (This should have been in the commit message IMO.)
> 
> 
> But that leads me to the question, since there is support for Tegra234
> SoC in the driver, does this means that this fixes a regression, e.g.
> the Kconfig ARCH_TEGRA_234_SOC was added after the driver support in
> this driver was added. In this case, you should have a Fixes: tag that
> points to the commit that added ARCH_TEGRA_234_SOC.
> 
> Or has the the driver support for Tegra234 been "dead-code" since it
> was originally added? (Because without this patch, no one can have
> tested it, at least not without COMPILE_TEST.)
> In this case, you should add:
> Fixes: a54e19073718 ("PCI: tegra194: Add Tegra234 PCIe support")
> 
> 
> Kind regards,
> Niklas

-- 
மணிவண்ணன் சதாசிவம்