linux-kernel - Re: [PATCH 2/2] scripts: generate_rust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ-ks9mK1uma-xN-=z6Y8OkrJB6=rppcx5njyCGGsz2MkNLr2g@mail.gmail.com>
Date: Mon, 10 Feb 2025 13:02:54 -0500
From: Tamir Duberstein <tamird@...il.com>
To: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, Kees Cook <kees@...nel.org>, 
	Fiona Behrens <me@...enk.dev>, Martin Rodriguez Reboredo <yakoyoku@...il.com>, Asahi Lina <lina@...hilina.net>
Cc: Boris-Chengbiao Zhou <bobo1239@....de>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] scripts: generate_rust_analyzer.py: add uapi crate

On Mon, Feb 10, 2025 at 12:56 PM Tamir Duberstein <tamird@...il.com> wrote:
>
> Commit 4e1746656839 ("rust: uapi: Add UAPI crate") did not update
> rust-analyzer to include the new crate.
>
> Add the missing definition to improve the developer experience.
>
> Fixes: 4e1746656839 ("rust: uapi: Add UAPI crate")
> Signed-off-by: Tamir Duberstein <tamird@...il.com>
> ---
>  scripts/generate_rust_analyzer.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
> index 1f573d19cd99..ee4f01ada277 100755
> --- a/scripts/generate_rust_analyzer.py
> +++ b/scripts/generate_rust_analyzer.py
> @@ -105,6 +105,7 @@ def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs):
>          }
>
>      append_crate_with_generated("bindings", ["core"])
> +    append_crate_with_generated("uapi", ["core"])
>      append_crate_with_generated("kernel", ["core", "macros", "build_error", "bindings"])
>
>      def is_root_crate(build_file, target):
>
> --
> 2.48.1
>

Oops, missing core dependency on uapi.