linux-kernel - Re: [RFC PATCH 6/6] debugfs: Replace debugfs_node #define with struct wrapping dentry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250210055858.GA1977892@ZenIV>
Date: Mon, 10 Feb 2025 05:58:58 +0000
From: Al Viro <viro@...iv.linux.org.uk>
To: David Reaver <me@...idreaver.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J . Wysocki" <rafael@...nel.org>,
	Danilo Krummrich <dakr@...nel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Christian Brauner <brauner@...nel.org>,
	linux-fsdevel@...r.kernel.org, cocci@...ia.fr,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 6/6] debugfs: Replace debugfs_node #define with
 struct wrapping dentry

On Sun, Feb 09, 2025 at 09:20:26PM -0800, David Reaver wrote:

> +static inline struct debugfs_node *dentry_to_node(struct dentry *dentry)
> +{
> +	return container_of(dentry, struct debugfs_node, dentry);
> +}

No.  And you don't have any fields left in struct dentry to replace
that with following a pointer.

Again, do not embed struct dentry into any other object; you are not just
doing that on temporary basis, it's left in that form by the end of the
series.  No go.

NAKed-by: Al Viro <viro@...iv.linux.org.uk>