linux-kernel - Re: [PATCH net-next v3 09/15] mptcp: pm: make three pm wrappers static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250210195139.GW554665@kernel.org>
Date: Mon, 10 Feb 2025 19:51:39 +0000
From: Simon Horman <horms@...nel.org>
To: "Matthieu Baerts (NGI0)" <matttbe@...nel.org>
Cc: mptcp@...ts.linux.dev, Mat Martineau <martineau@...nel.org>,
	Geliang Tang <geliang@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 09/15] mptcp: pm: make three pm wrappers
 static

On Fri, Feb 07, 2025 at 02:59:27PM +0100, Matthieu Baerts (NGI0) wrote:
> From: Geliang Tang <tanggeliang@...inos.cn>
> 
> Three netlink functions:
> 
> 	mptcp_pm_nl_get_addr_doit()
> 	mptcp_pm_nl_get_addr_dumpit()
> 	mptcp_pm_nl_set_flags_doit()
> 
> are generic, implemented for each PM, in-kernel PM and userspace PM. It's
> clearer to move them from pm_netlink.c to pm.c.
> 
> And the linked three path manager wrappers
> 
> 	mptcp_pm_get_addr()
> 	mptcp_pm_dump_addr()
> 	mptcp_pm_set_flags()
> 
> can be changed as static functions, no need to export them in protocol.h.
> 
> Signed-off-by: Geliang Tang <tanggeliang@...inos.cn>
> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>

Reviewed-by: Simon Horman <horms@...nel.org>