linux-kernel - Re: [PATCH RESEND v2 1/2] block: introduce init_wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z6pqmrc8stUHBJHS@slm.duckdns.org>
Date: Mon, 10 Feb 2025 11:07:38 -1000
From: Tejun Heo <tj@...nel.org>
To: Muchun Song <songmuchun@...edance.com>
Cc: axboe@...nel.dk, yukuai1@...weicloud.com, chengming.zhou@...ux.dev,
	muchun.song@...ux.dev, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH RESEND v2 1/2] block: introduce init_wait_func()

On Sat, Feb 08, 2025 at 05:04:15PM +0800, Muchun Song wrote:
> There is already a macro DEFINE_WAIT_FUNC() to declare a wait_queue_entry
> with a specified waking function. But there is not a counterpart for
> initializing one wait_queue_entry with a specified waking function. So
> introducing init_wait_func() for this, which also could be used in iocost
> and rq-qos. Using default_wake_function() in rq_qos_wait() to wake up
> waiters, which could remove ->task field from rq_qos_wait_data.
> 
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Signed-off-by: Muchun Song <songmuchun@...edance.com>

For rq-qos / blk-iocost part:

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun