linux-kernel - Re: [PATCH v7 7/7] drm/msm/hdmi: use DRM HDMI Audio framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a91da500-b575-4071-9c2b-e03c9c737144@quicinc.com>
Date: Mon, 10 Feb 2025 14:26:00 -0800
From: Abhinav Kumar <quic_abhinavk@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Andrzej Hajda
	<andrzej.hajda@...el.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Robert
 Foss <rfoss@...nel.org>,
        Laurent Pinchart
	<Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej
 Skrabec <jernej.skrabec@...il.com>,
        Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>, Rob Clark <robdclark@...il.com>,
        Sean Paul <sean@...rly.run>,
        Marijn Suijten
	<marijn.suijten@...ainline.org>,
        Simona Vetter <simona@...ll.ch>,
        Simona
 Vetter <simona.vetter@...ll.ch>
CC: <dri-devel@...ts.freedesktop.org>, <linux-arm-msm@...r.kernel.org>,
        <freedreno@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 7/7] drm/msm/hdmi: use DRM HDMI Audio framework



On 2/7/2025 4:27 PM, Dmitry Baryshkov wrote:
> In order to simplify the driver even further and to remove the
> boilerplate code, rewrite the audio interface to use the DRM HDMI Audio
> framework.
> 
> Audio InfoFames are controlled centrally via the DRM HDMI framework.
> Correct InfoFrame data is programmed at the atomic_pre_enable() time (if
> it was set before, drm_atomic_helper_connector_hdmi_update_infoframes()
> takes care of writing all InfoFrames, including the Audio one.) or
> during msm_hdmi_bridge_audio_prepare() when the new stream is started.
> 
> All audio data frame management is deferred to
> msm_hdmi_bridge_audio_prepare() and msm_hdmi_bridge_audio_shutdown().
> 
> Reviewed-by: Maxime Ripard <mripard@...nel.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> ---
>   drivers/gpu/drm/msm/hdmi/hdmi.c        | 91 ----------------------------------
>   drivers/gpu/drm/msm/hdmi/hdmi.h        | 18 +++----
>   drivers/gpu/drm/msm/hdmi/hdmi_audio.c  | 68 +++++++++++++++++++++----
>   drivers/gpu/drm/msm/hdmi/hdmi_bridge.c |  5 ++
>   4 files changed, 71 insertions(+), 111 deletions(-)
> 

Reviewed-by: Abhinav Kumar <quic_abhinavk@...cinc.com>