linux-kernel - Re: [PATCH v2 44/45] ASoC: fsl: imx-pcm-fiq: Switch to use hrtimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jz9yurtr.wl-tiwai@suse.de>
Date: Mon, 10 Feb 2025 09:28:16 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Nam Cao <namcao@...utronix.de>
Cc: Anna-Maria Behnsen <anna-maria@...utronix.de>,
	Frederic Weisbecker <frederic@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org,
	Zack Rusin <zack.rusin@...adcom.com>,
	Takashi Iwai <tiwai@...e.com>,
	Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v2 44/45] ASoC: fsl: imx-pcm-fiq: Switch to use hrtimer_setup()

On Wed, 05 Feb 2025 11:46:32 +0100,
Nam Cao wrote:
> 
> hrtimer_setup() takes the callback function pointer as argument and
> initializes the timer completely.
> 
> Replace hrtimer_init() and the open coded initialization of
> hrtimer::function with the new setup mechanism.
> 
> Patch was created by using Coccinelle.
> 
> Acked-by: Zack Rusin <zack.rusin@...adcom.com>
> Signed-off-by: Nam Cao <namcao@...utronix.de>
> Cc: Takashi Iwai <tiwai@...e.com>

Adding Mark to Cc, as ASoC is managed by him primarily.


thanks,

Takashi

> ---
>  sound/soc/fsl/imx-pcm-fiq.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/soc/fsl/imx-pcm-fiq.c b/sound/soc/fsl/imx-pcm-fiq.c
> index 3391430e4253..83de3ae33691 100644
> --- a/sound/soc/fsl/imx-pcm-fiq.c
> +++ b/sound/soc/fsl/imx-pcm-fiq.c
> @@ -185,8 +185,7 @@ static int snd_imx_open(struct snd_soc_component *component,
>  
>  	atomic_set(&iprtd->playing, 0);
>  	atomic_set(&iprtd->capturing, 0);
> -	hrtimer_init(&iprtd->hrt, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
> -	iprtd->hrt.function = snd_hrtimer_callback;
> +	hrtimer_setup(&iprtd->hrt, snd_hrtimer_callback, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
>  
>  	ret = snd_pcm_hw_constraint_integer(substream->runtime,
>  			SNDRV_PCM_HW_PARAM_PERIODS);
> -- 
> 2.39.5
>