linux-kernel - Re: [PATCH v4 1/3] vfs: add initial support for CONFIG_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250210-umgibt-vorhof-5d2eb09918e2@brauner>
Date: Mon, 10 Feb 2025 09:28:56 +0100
From: Christian Brauner <brauner@...nel.org>
To: Mateusz Guzik <mjguzik@...il.com>
Cc: viro@...iv.linux.org.uk, jack@...e.cz, linux-kernel@...r.kernel.org, 
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v4 1/3] vfs: add initial support for CONFIG_DEBUG_VFS

On Sun, Feb 09, 2025 at 07:55:20PM +0100, Mateusz Guzik wrote:
> Small collection of macros taken from mmdebug.h
> 
> Signed-off-by: Mateusz Guzik <mjguzik@...il.com>
> ---
>  fs/inode.c               | 15 ++++++++++++++
>  include/linux/fs.h       |  1 +
>  include/linux/vfsdebug.h | 45 ++++++++++++++++++++++++++++++++++++++++
>  lib/Kconfig.debug        |  9 ++++++++
>  4 files changed, 70 insertions(+)
>  create mode 100644 include/linux/vfsdebug.h
> 
> diff --git a/fs/inode.c b/fs/inode.c
> index 5587aabdaa5e..875e66261f06 100644
> --- a/fs/inode.c
> +++ b/fs/inode.c
> @@ -2953,3 +2953,18 @@ umode_t mode_strip_sgid(struct mnt_idmap *idmap,
>  	return mode & ~S_ISGID;
>  }
>  EXPORT_SYMBOL(mode_strip_sgid);
> +
> +#ifdef CONFIG_DEBUG_VFS
> +/*
> + * Dump an inode.
> + *
> + * TODO: add a proper inode dumping routine, this is a stub to get debug off the
> + * ground.
> + */
> +void dump_inode(struct inode *inode, const char *reason)
> +{
> +       pr_warn("%s encountered for inode %px", reason, inode);

I had already fixed that in the local tree. But thanks for resending.
I'll take v4 then.