linux-kernel - [PATCH] maple_tree: Remove redundant mte_to_node() in mte_dead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250210083526.252955-1-richard120310@gmail.com>
Date: Mon, 10 Feb 2025 16:35:26 +0800
From: I Hsin Cheng <richard120310@...il.com>
To: Liam.Howlett@...cle.com
Cc: akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org,
	maple-tree@...ts.infradead.org,
	linux-mm@...ck.org,
	jserv@...s.ncku.edu.tw,
	skhan@...uxfoundation.org,
	I Hsin Cheng <richard120310@...il.com>
Subject: [PATCH] maple_tree: Remove redundant mte_to_node() in mte_dead_node()

In mte_dead_node(), it already assign "node" as "mte_to_node(enode)" in
the first place, calling "mte_parent(enode)" will result in the same
"mte_to_node(enode)" again which is redundant.

Refactor mte_dead_node() and utilize ma_dead_node() to perform the
parent check without the redundant "mte_to_node()".

Signed-off-by: I Hsin Cheng <richard120310@...il.com>
---
 lib/maple_tree.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index f7153ade1be5..362f85c62678 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -584,13 +584,10 @@ static __always_inline bool ma_dead_node(const struct maple_node *node)
  */
 static __always_inline bool mte_dead_node(const struct maple_enode *enode)
 {
-	struct maple_node *parent, *node;
+	struct maple_node *node;
 
 	node = mte_to_node(enode);
-	/* Do not reorder reads from the node prior to the parent check */
-	smp_rmb();
-	parent = mte_parent(enode);
-	return (parent == node);
+	return ma_dead_node(node);
 }
 
 /*
-- 
2.43.0