lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z6nCPppxZEr-mlGQ@pollux>
Date: Mon, 10 Feb 2025 10:09:18 +0100
From: Danilo Krummrich <dakr@...nel.org>
To: Pyrex <economicsbat@...il.com>
Cc: abdiel.janulgue@...il.com, a.hindborg@...nel.org, airlied@...hat.com,
	alex.gaynor@...il.com, aliceryhl@...gle.com, benno.lossin@...ton.me,
	bjorn3_gh@...tonmail.com, boqun.feng@...il.com,
	daniel.almeida@...labora.com, gary@...yguo.net, hch@....de,
	iommu@...ts.linux.dev, kernel@...entinobst.de,
	linux-kernel@...r.kernel.org, m.szyprowski@...sung.com,
	ojeda@...nel.org, robin.murphy@....com,
	rust-for-linux@...r.kernel.org, tmgross@...ch.edu
Subject: Re: [PATCH v8 0/2] Add dma coherent allocator abstraction

Hi,

On Mon, Feb 10, 2025 at 12:54:25AM -0800, Pyrex wrote:
> I'm nervy about the Rust code here.

Code reviews are always welcome!

However, please make sure to consider the following.

When sending feedback, please try to keep up with the latest version [1] of the
patchset.

Please send your comments inline keeping the relevant context and removing the
irrelevant parts in your reply. Otherwise it is impossible to have a discussion
that everyone can follow.

Thanks!

[1] https://lore.kernel.org/rust-for-linux/20250123104333.1340512-1-abdiel.janulgue@gmail.com/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ