linux-kernel - Re: [PATCH 3/3] iio: chemical: add support for Sensirion SEN5x/SEN6x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1237314b-78a8-a871-ea24-f3011766606b@axis.com>
Date: Mon, 10 Feb 2025 17:16:57 +0800
From: Hermes Zhang <chenhuiz@...s.com>
To: Jonathan Cameron <jic23@...nel.org>, Hermes Zhang <Hermes.Zhang@...s.com>
Cc: robh@...nel.org, lars@...afoo.de, krzk+dt@...nel.org, kernel@...s.com,
 linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH 3/3] iio: chemical: add support for Sensirion SEN5x/SEN6x

Hi Jonathan,

Thanks a lot for your review. I will fix most of them in v2, just one 
question below.

Best Regards,
Hermes


On 2025/2/9 0:15, Jonathan Cameron wrote:
> On Thu, 6 Feb 2025 14:15:17 +0800
> Hermes Zhang <Hermes.Zhang@...s.com> wrote:
>
>
>> +
>> +	state->last_update = jiffies;
>> +
>> +	return 0;
>> +}
>> +
>> +static ssize_t status_show(struct device *dev, struct device_attribute *attr,
>> +			   char *buf)
>> +{
>> +	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>> +	struct sen_common_state *state = iio_priv(indio_dev);
>> +	int status;
>> +	int ret;
>> +
>> +	ret = sen_common_status(state->client, &status);
> This is custom ABI. So it would need documentation and will need
> to overcome quite a high barrier.
>
> Superficially this looks like debug perhaps that should be
> in debugfs?

The status is one of the support commands from the chip, we (from 
userspace) could read it and notify customer if the sensor is wrong or 
not. So it is ued in normal usage, regarding the ABI, I see your point, 
so instead of my way, do you have any suggestion for how to handle it in 
iio? Thanks.

Best Regards,

Hermes