linux-kernel - Re: [PATCH 1/1] mm: Remove the access_ok() call from gup_fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62670dc0-216a-4e59-a6c1-889065efb529@redhat.com>
Date: Mon, 10 Feb 2025 10:23:54 +0100
From: David Hildenbrand <david@...hat.com>
To: David Laight <david.laight.linux@...il.com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Linus Torvalds <torvalds@...ux-foundation.org>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, x86@...nel.org
Cc: Jason Gunthorpe <jgg@...dia.com>, Jan Kara <jack@...e.cz>,
 John Hubbard <jhubbard@...dia.com>, Peter Xu <peterx@...hat.com>,
 Dave Hansen <dave.hansen@...ux.intel.com>, Andy Lutomirski
 <luto@...nel.org>, Peter Zijlstra <peterz@...radead.org>,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH 1/1] mm: Remove the access_ok() call from
 gup_fast_fallback().

On 09.02.25 18:47, David Laight wrote:
> Historiaclly the code relied on access_ok() to validate the address range.
> Commit 26f4c328079d7 added an explicit wrap check before access_ok().
> Commit c28b1fc70390d then changed the wrap test to use check_add_overflow().
> Commit 6014bc27561f2 relaxed the checks in x86-64's access_ok() and added

checkpatch.pl will correctly tell you about the wrongly quoted commit ids.

E.g.,

ERROR: Please use git commit description style 'commit <12+ chars of 
sha1> ("<title line>")' - ie: 'Commit 26f4c328079d ("mm: simplify 
gup_fast_permitted")'

Apart from that

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb