linux-kernel - Re: [PATCH v3] sched/topology: Enable topology_span

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3884226-b145-4960-b5c8-ca8284aff9ef@linux.microsoft.com>
Date: Mon, 10 Feb 2025 15:23:19 +0530
From: Naman Jain <namjain@...ux.microsoft.com>
To: K Prateek Nayak <kprateek.nayak@....com>, Ingo Molnar <mingo@...hat.com>,
 Peter Zijlstra <peterz@...radead.org>, Juri Lelli <juri.lelli@...hat.com>,
 Vincent Guittot <vincent.guittot@...aro.org>,
 Dietmar Eggemann <dietmar.eggemann@....com>,
 Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>,
 Mel Gorman <mgorman@...e.de>, Valentin Schneider <vschneid@...hat.com>
Cc: stable@...r.kernel.org, linux-kernel@...r.kernel.org,
 Steve Wahl <steve.wahl@....com>,
 Saurabh Singh Sengar <ssengar@...ux.microsoft.com>, srivatsa@...il.mit.edu,
 Michael Kelley <mhklinux@...look.com>, namjain@...ux.microsoft.com
Subject: Re: [PATCH v3] sched/topology: Enable topology_span_sane check only
 for debug builds



On 2/5/2025 12:53 PM, Naman Jain wrote:
> 
> 
> On 2/5/2025 12:50 PM, K Prateek Nayak wrote:
>> Hello Naman,
>>
>> On 2/3/2025 5:17 PM, Naman Jain wrote:
>>> From: Saurabh Sengar <ssengar@...ux.microsoft.com>
>>>
>>> On a x86 system under test with 1780 CPUs, topology_span_sane() takes
> 
> <.>
> 
>>>   {
>>>       int i = cpu + 1;
>>> +    /* Skip the topology sanity check for non-debug, as it is a 
>>> time- consuming operatin */
>>
>> s/operatin/operation/
>>
>>> +    if (!sched_debug()) {
>>> +        pr_info_once("%s: Skipping topology span sanity check. Use 
>>> `sched_verbose` boot parameter to enable it.\n",
>>
>> This could be broken down as follows:
>>
>>          pr_info_once("%s: Skipping topology span sanity check."
>>                   " Use `sched_verbose` boot parameter to enable it.\n",
>>                   __func__);
>>
>> Running:
>>
>>      grep -r -A 5 "pr_info(.*[^;,]$" kernel/
>>
>> gives similar usage across kernel/*. Apart from those nits, feel
>> free to add:
>>
>> Tested-by: K Prateek Nayak <kprateek.nayak@....com> # x86
>>
>> if the future version does not change much.
>>
> 
> Hello Prateek,
> Thanks for reviewing and testing this. I'll make changes based on your
> feedback in next version.
> 
> Regards,
> Naman
> 

Hi Prateek,
After breaking down the print msg based on your suggestion, checkpatch
gives a warning. There are no warnings reported with current version of
change. Even the fix suggested by checkpatch is aligned to what we have
right now. So I'll keep it like this, not push further changes as of now
and wait for the maintainers to pick the patch.

WARNING: quoted string split across lines
#57: FILE: kernel/sched/topology.c:2365:
+               pr_info_once("%s: Skipping topology span sanity check."
+                            " Use `sched_verbose` boot parameter to
enable it.\n",

total: 0 errors, 1 warnings, 14 lines checked

Regards,
Naman