linux-kernel - Re: [PATCH net-next 08/15] net/mlx5e: set the tx_queue_len for pfifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z6nMBi26yyFjQQJK@mev-dev.igk.intel.com>
Date: Mon, 10 Feb 2025 10:51:02 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org,
	Saeed Mahameed <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>,
	Leon Romanovsky <leonro@...dia.com>,
	Simon Horman <horms@...nel.org>,
	Donald Hunter <donald.hunter@...il.com>,
	Jiri Pirko <jiri@...nulli.us>, Jonathan Corbet <corbet@....net>,
	Leon Romanovsky <leon@...nel.org>,
	Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Jesper Dangaard Brouer <hawk@...nel.org>,
	John Fastabend <john.fastabend@...il.com>,
	Richard Cochran <richardcochran@...il.com>,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-rdma@...r.kernel.org, bpf@...r.kernel.org,
	William Tu <witu@...dia.com>, Daniel Jurgens <danielj@...dia.com>
Subject: Re: [PATCH net-next 08/15] net/mlx5e: set the tx_queue_len for
 pfifo_fast

On Sun, Feb 09, 2025 at 12:17:09PM +0200, Tariq Toukan wrote:
> From: William Tu <witu@...dia.com>
> 
> By default, the mq netdev creates a pfifo_fast qdisc. On a
> system with 16 core, the pfifo_fast with 3 bands consumes
> 16 * 3 * 8 (size of pointer) * 1024 (default tx queue len)
> = 393KB. The patch sets the tx qlen to representor default
> value, 128 (1<<MLX5E_REP_PARAMS_DEF_LOG_SQ_SIZE), which
> consumes 16 * 3 * 8 * 128 = 49KB, saving 344KB for each
> representor at ECPF.
> 
> Signed-off-by: William Tu <witu@...dia.com>
> Reviewed-by: Daniel Jurgens <danielj@...dia.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> index da399adc8854..07f38f472a27 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
> @@ -889,6 +889,8 @@ static void mlx5e_build_rep_netdev(struct net_device *netdev,
>  	netdev->ethtool_ops = &mlx5e_rep_ethtool_ops;
>  
>  	netdev->watchdog_timeo    = 15 * HZ;
> +	if (mlx5_core_is_ecpf(mdev))
> +		netdev->tx_queue_len = 1 << MLX5E_REP_PARAMS_DEF_LOG_SQ_SIZE;
>  
>  #if IS_ENABLED(CONFIG_MLX5_CLS_ACT)
>  	netdev->hw_features    |= NETIF_F_HW_TC;

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

> -- 
> 2.45.0