linux-kernel - Re: [PATCH v3 2/2] counter: microchip-tcb-capture: Add capture extensions for registers RA-RC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4c8a847d-b506-4235-9941-06e0d403cb62@prolan.hu>
Date: Mon, 10 Feb 2025 10:56:34 +0100
From: Csókás Bence <csokas.bence@...lan.hu>
To: <Dharma.B@...rochip.com>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC: <kamel.bouhara@...tlin.com>, <wbg@...nel.org>
Subject: Re: [PATCH v3 2/2] counter: microchip-tcb-capture: Add capture
 extensions for registers RA-RC

Hi,

On 2025. 02. 07. 9:19, Dharma.B@...rochip.com wrote:
> The registers RA/B/C are 32 bit registers, hence use of u64 is unnecessary.

Correct, but the definition of COUNTER_COMP_ARRAY_CAPTURE 
(include/linux/counter.h:623) is:

	#define COUNTER_COMP_ARRAY_CAPTURE(_read, _write, _array) \
		COUNTER_COMP_COUNT_ARRAY_U64("capture", _read, _write, _array)

> The regmap_read() returns an error code, which is currently ignored. If
> regmap_read() fails, cnt remains uninitialized, potentially returning
> garbage data.

Will fix.

Thanks,
Bence