linux-kernel - Re: [PATCH v4 3/6] dt-bindings: net: dwmac: add compatible for Agilex5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250210-hissing-discerning-vulture-d741cd@krzk-bin>
Date: Mon, 10 Feb 2025 11:23:59 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Steffen Trumtrar <s.trumtrar@...gutronix.de>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Dinh Nguyen <dinguyen@...nel.org>, kernel@...gutronix.de, netdev@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/6] dt-bindings: net: dwmac: add compatible for
 Agilex5

On Wed, Feb 05, 2025 at 04:32:24PM +0100, Steffen Trumtrar wrote:
> The Agilex5 SoCs have three Synopsys DWXGMAC-compatible ethernet
> IP-cores.
> 
> Add a SoC-specific front compatible to the binding.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@...gutronix.de>
> ---
>  Documentation/devicetree/bindings/net/socfpga-dwmac.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/socfpga-dwmac.yaml b/Documentation/devicetree/bindings/net/socfpga-dwmac.yaml
> index 2568dd90f4555485f18912b5352f191824bb918c..31c163bf1b59e14216d1fb4b4b9aaa747e1b19e2 100644
> --- a/Documentation/devicetree/bindings/net/socfpga-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/socfpga-dwmac.yaml
> @@ -21,6 +21,7 @@ select:
>          enum:
>            - altr,socfpga-stmmac # For Cyclone5/Arria5 SoCs
>            - altr,socfpga-stmmac-a10-s10 # For Arria10/Agilex/Stratix10 SoCs
> +          - altr,socfpga-stmmac-agilex5 # For Agilex5 SoCs
>    required:
>      - compatible
>  
> @@ -45,6 +46,12 @@ properties:
>                - altr,socfpga-stmmac-a10-s10
>            - const: snps,dwmac-3.74a
>            - const: snps,dwmac
> +      - items:
> +          - enum:
> +              - altr,socfpga-stmmac-agilex5
> +          - const: altr,socfpga-stmmac-a10-s10
> +          - const: snps,dwxgmac-2.10

No, don't grow this pattern. a10-s10 *MUST* be one specific device, so
it cannot be compatible with 3.72, 3.74 and 2.10 in the same time.

I understand that old DTS was here wrong, that ship has failed, but
don't grow it. All your compatibles must be specific, which means they
must represent one logical choice. You claim now that a10-s10 covers now
three entirely different devices.

Best regards,
Krzysztof