linux-kernel - Re: [PATCH] x86/efistub: Add options for forcing Apple set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXFdm-3+zFejU+=78R5P80e9SiB9Tr-8W-zLjub5njL3sg@mail.gmail.com>
Date: Mon, 10 Feb 2025 11:40:47 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Aditya Garg <gargaditya08@...e.com>
Cc: Lleyton Gray <lleyton@...alabs.com>, Jonathan Corbet <corbet@....net>, 
	"Paul E. McKenney" <paulmck@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>, 
	Thomas Huth <thuth@...hat.com>, Steven Rostedt <rostedt@...dmis.org>, 
	Xiongwei Song <xiongwei.song@...driver.com>, Jeremy Linton <jeremy.linton@....com>, 
	Ilias Apalodimas <ilias.apalodimas@...aro.org>, 
	Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>, 
	Jonathan Marek <jonathan@...ek.ca>, "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, 
	Kees Cook <kees@...nel.org>, "Borislav Petkov (AMD)" <bp@...en8.de>, 
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>, Lukas Wunner <lukas@...ner.de>
Subject: Re: [PATCH] x86/efistub: Add options for forcing Apple set_os protocol

Hi Aditya,

On Sun, 9 Feb 2025 at 17:13, Aditya Garg <gargaditya08@...e.com> wrote:
>
> Hi all
>

Please don't top post.

> I managed to get feedbacks regarding eGPUs on older non T2 MacBooks, and can confirm that apple-set-os is needed there as well.
>

This is rather vague. Where did you get this feedback, and what
systems does it cover?

Also, this is not about being able to switch to the integrated GPU to
drive the built-in panel, but for driving an external GPU connected to
a different screen altogether. AIUI, this has never worked on these
systems, right? So why is this important now, for 10 year old
Macbooks?

> I was wondering if we can reach a conclusion for this case here.
>

I'd prefer to address this in a different way: instead of fixing this
in the Linux kernel for the handful of systems that need this (and
that will upgrade to v6.15 or later to get this fix), why not use a
separate boot-time EFI app to call the protocol. That way, it works
with existing kernels too, and no changes are needed to Linux.

https://paste.debian.net/1349311/