linux-kernel - Re: [PATCH v1 1/2] PM: EM: Drop unused parameter from em_adjust_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <764b2869-8023-45b2-bae9-5a24be1ea519@arm.com>
Date: Mon, 10 Feb 2025 11:25:07 +0000
From: Lukasz Luba <lukasz.luba@....com>
To: "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc: LKML <linux-kernel@...r.kernel.org>, Linux PM <linux-pm@...r.kernel.org>,
 Dietmar Eggemann <dietmar.eggemann@....com>,
 Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>
Subject: Re: [PATCH v1 1/2] PM: EM: Drop unused parameter from
 em_adjust_new_capacity()

On 1/27/25 13:37, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> The max_cap parameter is never used in em_adjust_new_capacity(), so
> drop it.
> 
> No functional impact.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
>   kernel/power/energy_model.c |    5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> --- a/kernel/power/energy_model.c
> +++ b/kernel/power/energy_model.c
> @@ -728,8 +728,7 @@
>    * are correctly calculated.
>    */
>   static void em_adjust_new_capacity(struct device *dev,
> -				   struct em_perf_domain *pd,
> -				   u64 max_cap)
> +				   struct em_perf_domain *pd)
>   {
>   	struct em_perf_table __rcu *em_table;
>   
> @@ -800,7 +799,7 @@
>   			 cpu, cpu_capacity, em_max_perf);
>   
>   		dev = get_cpu_device(cpu);
> -		em_adjust_new_capacity(dev, pd, cpu_capacity);
> +		em_adjust_new_capacity(dev, pd);
>   	}
>   
>   	free_cpumask_var(cpu_done_mask);
> 
> 
> 

LGTM

Reviewed-by: Lukasz Luba <lukasz.luba@....com>