linux-kernel - Re: [PATCH v3] rust/kernel: Add faux device bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025021030-glorified-pasture-e249@gregkh>
Date: Mon, 10 Feb 2025 12:31:05 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Lyude Paul <lyude@...hat.com>
Cc: rust-for-linux@...r.kernel.org,
	Maíra Canal <mairacanal@...eup.net>,
	Danilo Krummrich <dakr@...nel.org>,
	Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
	Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Wedson Almeida Filho <wedsonaf@...il.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Xiangfei Ding <dingxiangfei2009@...il.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] rust/kernel: Add faux device bindings

On Fri, Feb 07, 2025 at 06:49:25PM -0500, Lyude Paul wrote:
> This introduces a module for working with faux devices in rust, along with
> adding sample code to show how the API is used. Unlike other types of
> devices, we don't provide any hooks for device probe/removal - since these
> are optional for the faux API and are unnecessary in rust.
> 
> Signed-off-by: Lyude Paul <lyude@...hat.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Maíra Canal <mairacanal@...eup.net>
> Cc: Danilo Krummrich <dakr@...nel.org>
> Cc: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
> 
> ---
> V2:
> * Check for NULL on return from device_create(), not a pointer error
> * Rename Device to Registration to make its purpose more clear
> * Drop platform device comment from crate docstring.
> * Update MAINTAINERS
> V3:
> * Clarify safety comment around thread-safety
> * Return ENODEV on failure from new()
> * Add missing newline in faux driver sample
> * s/crate/module/ in descriptions
> * Add newline after faux module docstring
> * Fix missing markdown in safety comments
> * Add missing INVARIANT: comment in Registration
> * s/Registration/faux::Registration/ in rust_driver_faux.rs

Thanks, I've taken this into my series and fixed up the api where I
added a "parent" pointer.  I'll send it out in a bit...

thanks,

greg k-h