linux-kernel - Re: [PATCH 2/4] ASoC: SOF: amd: Drop unused includes from Vangogh driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f84884e-62e6-4b43-aa86-e1fe03507631@amd.com>
Date: Mon, 10 Feb 2025 17:08:14 +0530
From: potturu venkata prasad <venkataprasad.potturu@....com>
To: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>,
 Liam Girdwood <lgirdwood@...il.com>,
 Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
 Bard Liao <yung-chuan.liao@...ux.intel.com>,
 Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
 Daniel Baluta <daniel.baluta@....com>,
 Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
 Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>,
 Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
 Takashi Iwai <tiwai@...e.com>, Vijendar Mukunda <Vijendar.Mukunda@....com>
Cc: kernel@...labora.com, sound-open-firmware@...a-project.org,
 linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] ASoC: SOF: amd: Drop unused includes from Vangogh
 driver


On 2/7/25 17:16, Cristian Ciocaltea wrote:
> Remove all the includes for headers which are not (directly) used from
> the Vangogh SOF driver sources.

Okay.

Reviewed-by: Venkata Prasad Potturu <venkataprasad.potturu@....com>

>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
> ---
>   sound/soc/sof/amd/pci-vangogh.c | 2 --
>   sound/soc/sof/amd/vangogh.c     | 4 ----
>   2 files changed, 6 deletions(-)
>
> diff --git a/sound/soc/sof/amd/pci-vangogh.c b/sound/soc/sof/amd/pci-vangogh.c
> index 53f64d6bc91bae9e2ec506384a83b209a296860f..28f2d4050a6769335b5908c16946eff85aa7161d 100644
> --- a/sound/soc/sof/amd/pci-vangogh.c
> +++ b/sound/soc/sof/amd/pci-vangogh.c
> @@ -13,11 +13,9 @@
>   
>   #include <linux/module.h>
>   #include <linux/pci.h>
> -#include <linux/platform_device.h>
>   #include <sound/sof.h>
>   #include <sound/soc-acpi.h>
>   
> -#include "../ops.h"
>   #include "../sof-pci-dev.h"
>   #include "../../amd/mach-config.h"
>   #include "acp.h"
> diff --git a/sound/soc/sof/amd/vangogh.c b/sound/soc/sof/amd/vangogh.c
> index d5f1dddd43e72dd62b3d031130193e6125edf9df..6ed5f9aaa414e696b0ae9b3bb83bd92a5dcd8d4b 100644
> --- a/sound/soc/sof/amd/vangogh.c
> +++ b/sound/soc/sof/amd/vangogh.c
> @@ -12,13 +12,9 @@
>    */
>   
>   #include <linux/delay.h>
> -#include <linux/platform_device.h>
>   #include <linux/module.h>
>   
> -#include "../ops.h"
> -#include "../sof-audio.h"
>   #include "acp.h"
> -#include "acp-dsp-offset.h"
>   
>   #define I2S_HS_INSTANCE		0
>   #define I2S_BT_INSTANCE		1
>